Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const qualifier for void** in oroModuleLaunchKernel #97

Closed
yusuke-tokuyoshi opened this issue Dec 12, 2024 · 2 comments
Closed

Add const qualifier for void** in oroModuleLaunchKernel #97

yusuke-tokuyoshi opened this issue Dec 12, 2024 · 2 comments

Comments

@yusuke-tokuyoshi
Copy link

oroError_t OROAPI oroModuleLaunchKernel(oroFunction_t f, unsigned int gridDimX, unsigned int gridDimY, unsigned int gridDimZ, unsigned int blockDimX, unsigned int blockDimY, unsigned int blockDimZ, unsigned int sharedMemBytes, oroStream_t stream, void ** kernelParams, void ** extra);

Can we add const to void** as follows?

oroError_t OROAPI oroModuleLaunchKernel(oroFunction_t f, unsigned int gridDimX, unsigned int gridDimY, unsigned int gridDimZ, unsigned int blockDimX, unsigned int blockDimY, unsigned int blockDimZ, unsigned int sharedMemBytes, oroStream_t stream, const void *const * kernelParams, const void *const * extra);

I think this change allows us to input const-qualified parameters to oroModuleLaunchKernel.

@takahiroharada
Copy link

Yes we need to add. I realized this too.

@KaoCC
Copy link

KaoCC commented Dec 23, 2024

I posted to here :
GPUOpen-LibrariesAndSDKs#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants