Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to sdist #72

Closed
jayvdb opened this issue Feb 19, 2019 · 8 comments
Closed

Add license to sdist #72

jayvdb opened this issue Feb 19, 2019 · 8 comments
Assignees

Comments

@jayvdb
Copy link

jayvdb commented Feb 19, 2019

For packaging, would you mind including the license, tests, etc into the sdist uploaded to PyPI.

See .spec at https://build.opensuse.org/package/show/home:jayvdb:moban/python-amazon.ion

@jayvdb
Copy link
Author

jayvdb commented Feb 26, 2019

Typically this is done by creating a MANIFEST.in, with rules for which files to include and which to exclude.

However I believe in the next release it can also be done by configuring setuptools a little. See pypa/setuptools#1636

@tgregg
Copy link
Contributor

tgregg commented Feb 26, 2019

Hi @jayvdb, I will look into this.

@tgregg
Copy link
Contributor

tgregg commented Mar 2, 2019

@jayvdb , can you take a look at #76 and see if that will work for you?

@jayvdb
Copy link
Author

jayvdb commented Mar 2, 2019

I'm not sure about the side effects of using data_files for this - I've only used it to ship man pages.

@tgregg
Copy link
Contributor

tgregg commented Mar 4, 2019

I don't think there are any side-effects. data_files seems to be an alternative to using MANIFEST.in. The files are just copied to the sdist.

@jayvdb
Copy link
Author

jayvdb commented Mar 10, 2019

Fun and games #76 (comment)

@tgregg
Copy link
Contributor

tgregg commented Apr 19, 2019

Closed #76 in favor of #80 .

@tgregg
Copy link
Contributor

tgregg commented Apr 23, 2019

ion-python 0.4.0 has been released.

@tgregg tgregg closed this as completed Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants