New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate pooling large-capacity mutable lists and then copying to right-sized immutable lists in IonElementLoaderImpl #104

Open

popematt opened this issue Sep 9, 2024 · 0 comments

Labels

Contributor

popematt commented Sep 9, 2024

From #103 (comment)

I wonder if it would improve performance to pool these using something like IonJava's RecyclingStack. We could get away with having one per depth level right?

I'm intentionally not using a recycling stack because on L154, we wrap it in an immutable list, and then forget about the underlying mutable reference.
However, it would be worth investigating whether there is a performance benefit to having a pool of ArrayLists that have a relatively larger capacity, and then copying to an exact-sized immutable list.

popematt added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment