Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect should also show symbol numbers in symbol tables #34

Closed
jobarr-amzn opened this issue Sep 28, 2022 · 2 comments
Closed

inspect should also show symbol numbers in symbol tables #34

jobarr-amzn opened this issue Sep 28, 2022 · 2 comments

Comments

@jobarr-amzn
Copy link
Contributor

jobarr-amzn commented Sep 28, 2022

When presenting a symbol table each entry is shown as a string:

     3357 |        14 | 8d 6d 61 72 6b 65 74 70  |       "marketplaceId",
          |           | 6c 61 63 65 49 64        |
     3371 |        14 | 8d 6f 66 66 65 72 44 61  |       "offerDataList",
          |           | 74 61 4c 69 73 74        |
     3385 |         6 | 85 74 72 61 63 65        |       "trace",

Later when that symbol is used inspect helpfully provides the interpretation and not just the symbol ID:

  9701447 |        32 | de 9e                    |    {
  9701449 |         1 | c9                       |      'post_handler_type': // $73:
  9701450 |         2 | 71 d9                    |       trace, // $217

It would be convenient if the symbol table rendering presented the symbol number along with the text. Something like this?

     3357 |        14 | 8d 6d 61 72 6b 65 74 70  |       "marketplaceId", // $215
          |           | 6c 61 63 65 49 64        |
     3371 |        14 | 8d 6f 66 66 65 72 44 61  |       "offerDataList", // $216
          |           | 74 61 4c 69 73 74        |
     3385 |         6 | 85 74 72 61 63 65        |       "trace", // $217 (71 d9)
@zslayton
Copy link
Contributor

zslayton commented Jun 2, 2024

I've got this working in a new PR I'll open shortly.
image

@zslayton
Copy link
Contributor

zslayton commented Jun 3, 2024

Added in #113.

@zslayton zslayton closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants