Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimals.jl support #33

Closed
johnzl-777 opened this issue Feb 2, 2023 · 2 comments
Closed

Decimals.jl support #33

johnzl-777 opened this issue Feb 2, 2023 · 2 comments

Comments

@johnzl-777
Copy link

Describe the feature you'd like
The current Braket IR uses Dec128 from DecFP to represent the Decimal type but this relies on an external Intel library. It would be nice if Decimals.jl support could be added as a Julia-native option for the Decimal type.

How would this feature be used? Please describe.
There are plans for the Bloqade.jl schema to use Decimals.jl. If the Braket IR supported Decimals.jl it would make future IR conversions much easier 😃

Credit to @Roger-luo and @weinbe58 for the idea

@kshyatt-aws
Copy link
Contributor

The problem for us is that Decimals.jl seems pretty abandoned (last tagged version in 2020) and the Decimal type doesn't support hashing, for example. Is the reliance on an Intel library the main blocker for you? Would it be enough to modify Braket.jl to allow constructing the higher-level constructs using Decimal even if internally they use Dec128?

@weinbe58
Copy link

weinbe58 commented Feb 6, 2023

No, its not a blocker for us, It would be nice to have a pure Julia implementation to support the most platforms.

I think in the Long term a redesign of the IR will hopefully make this need for Dec128 obsolete, more details to come hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants