Carthage support + XCTests #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amayne I used your code to learn how to create Carthage packages using Thoughtbot's tutorial on creating frameworks.
I have also turned your phenomenal list of examples into XCTests that verify the code does what it's intended to do. The two functions that return NSDate are not as well-covered as the rest. I have to dig into my notes on how the class works.
Finally, I have tweaked the setup for Travis according to Carthage's instructions.
I have not properly tested support of Cocoapods, but I have edited the paths in the
.podspecfile, so that should probably do it.This would close #5, making the package more robust.