Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace SCSS/CSS files to a more portable approach #21

Open
gilbarbara opened this issue Jan 27, 2018 · 4 comments
Open

replace SCSS/CSS files to a more portable approach #21

gilbarbara opened this issue Jan 27, 2018 · 4 comments
Labels
breaking change enhancement
Milestone
1.0

Comments

@gilbarbara
Copy link
Contributor

gilbarbara commented Jan 27, 2018 •
edited
Loading

  • needs to handle keyframes and pseudo-elements
  • can't use a library since it would add coupling and big dependencies

One option is nano-css but I'll search for newer options anyway
@cassiocardoso
Copy link
Contributor

without any libs? 🤔

@efehelvaci
Copy link

If the project is created with create-react-app, it's not possible to use without ejecting.

@gilbarbara
Copy link
Contributor Author

@efeconirulez
You can import the css file.

import 'react-credit-cards/es/styles-compiled.css';

I've just added that to the README.

@gilbarbara
Copy link
Contributor Author

@cassiocardoso yeah, any thoughts? 🤓

@gilbarbara gilbarbara added this to the 1.0 milestone May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@gilbarbara @cassiocardoso @efehelvaci