Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 over jQuery #5

Closed
unruledboy opened this issue Nov 29, 2019 · 17 comments
Closed

ES6 over jQuery #5

unruledboy opened this issue Nov 29, 2019 · 17 comments
Assignees
Labels
enhancement New feature or request

Comments

@unruledboy
Copy link

One of the beauties of this project is to have minimum dependency, if we can use ES6 APIs to replace jQuery, it would be even more slim.

Like Element.querySelector over 1 element $('selector'), or Element.querySelectorAll() for multiple element $('selector').

@Githamza
Copy link

I am strongly interested to know if jQuery will be replaced by future js in future releases

@alyssaxuu
Copy link
Owner

That's definitely something that would greatly improve the library. I made it with jQuery for ease, but ES6 would remove all dependencies, making it even more minimal indeed. Going to look into it!

@alyssaxuu alyssaxuu self-assigned this Dec 2, 2019
@alyssaxuu alyssaxuu added the enhancement New feature or request label Dec 2, 2019
@Githamza
Copy link

Githamza commented Dec 2, 2019

I propose to create a new issue with list of next features to add. people could also submit their ideas in comments.

@DenysVuika
Copy link

This resource can help: http://youmightnotneedjquery.com/

@CeloGomesBR
Copy link

Uncaught TypeError: Cannot read property '0' of undefined
at HTMLDivElement.e (flowy.min.js:1)
at HTMLDocument.dispatch (jquery.min.js:2)
at HTMLDocument.v.handle (jquery.min.js:2)

@christianoerick
Copy link

TypeError: t.targetTouches is undefined264 flowy.min.js:1:11842

@alyssaxuu
Copy link
Owner

Uncaught TypeError: Cannot read property '0' of undefined
at HTMLDivElement.e (flowy.min.js:1)
at HTMLDocument.dispatch (jquery.min.js:2)
at HTMLDocument.v.handle (jquery.min.js:2)

TypeError: t.targetTouches is undefined264 flowy.min.js:1:11842

Fixed those issues, was a small typo.

@alyssaxuu alyssaxuu pinned this issue Dec 7, 2019
@benjaminaudet
Copy link

Did you begin to work on this @alyssaxuu ? I'm interested in fixing this issue in the two days comin'.
I like your work btw.

@alyssaxuu alyssaxuu unpinned this issue Dec 9, 2019
@alyssaxuu
Copy link
Owner

Did you begin to work on this @alyssaxuu ? I'm interested in fixing this issue in the two days comin'.
I like your work btw.

I've been working on it, although I've been a bit busy.

@yellow1912
Copy link

I can help you if you need any help. Definitely interested in removing jquery altogether.

@alyssaxuu
Copy link
Owner

I can help you if you need any help. Definitely interested in removing jquery altogether.

Feel free to contribute ^^ I haven't really done much progress with it yet since I don't have the time for it right now, I could dive into it this weekend.

@diegonvs
Copy link

https://github.com/google/closure-library/tree/master/closure/goog can be another resource for good and wide-compat code :)

@diegonvs
Copy link

How can we split tasks? 🤔

@benjaminaudet
Copy link

I've begin to work on my fork. I've start cleaning the code, begin to use ES6 features, but not yet moving from JQuery to plain javascript. I guess we could define some types of JQuery calls, group them by category and each of us takes care on his category, what do you think about that ?

@yellow1912
Copy link

I think we can do that: splitting the features to make it easier to collaborate.

Code can be written in ES6 then ported back to ES5 using the Babel transpiler.

@ghost
Copy link

ghost commented Dec 13, 2019

So I'm not that great at javascript, but I have a lot of time on my hands so I did my best at converting to ES6. There are some issues with alignment that are probably happening due to my inexperience, but hopefully it's useful to you. My fork

@alyssaxuu
Copy link
Owner

The project officially has no dependencies - got rid of jQuery! Thanks everyone for your contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants