feat(dashboard): 💄 Tweak graph labels and colors #3891
clippy
14 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 14 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956e 2024-04-29)
Annotations
Check warning on line 186 in alvr/client_openxr/src/lib.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:186:9
|
186 | let mut stream_config = None::<StreamConfig>;
| ----^^^^^^^^^^^^^
| |
| help: remove this `mut`
Check warning on line 185 in alvr/client_openxr/src/lib.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:185:9
|
185 | let mut last_lobby_message = String::new();
| ----^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
Check warning on line 198 in alvr/client_openxr/src/lib.rs
github-actions / clippy
unused variable: `xr_frame_stream`
warning: unused variable: `xr_frame_stream`
--> alvr/client_openxr/src/lib.rs:198:51
|
198 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`
Check warning on line 198 in alvr/client_openxr/src/lib.rs
github-actions / clippy
unused variable: `xr_frame_waiter`
warning: unused variable: `xr_frame_waiter`
--> alvr/client_openxr/src/lib.rs:198:30
|
198 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`
Check warning on line 198 in alvr/client_openxr/src/lib.rs
github-actions / clippy
unused variable: `xr_session`
warning: unused variable: `xr_session`
--> alvr/client_openxr/src/lib.rs:198:14
|
198 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`
Check warning on line 186 in alvr/client_openxr/src/lib.rs
github-actions / clippy
unused variable: `stream_config`
warning: unused variable: `stream_config`
--> alvr/client_openxr/src/lib.rs:186:13
|
186 | let mut stream_config = None::<StreamConfig>;
| ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream_config`
Check warning on line 185 in alvr/client_openxr/src/lib.rs
github-actions / clippy
unused variable: `last_lobby_message`
warning: unused variable: `last_lobby_message`
--> alvr/client_openxr/src/lib.rs:185:13
|
185 | let mut last_lobby_message = String::new();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 204 in alvr/client_openxr/src/lib.rs
github-actions / clippy
unreachable definition
warning: unreachable definition
--> alvr/client_openxr/src/lib.rs:204:13
|
200 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ------------------------------------------------ any code following this expression is unreachable
...
204 | let xr_context = XrContext {
| ^^^^^^^^^^ unreachable definition
|
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
--> alvr/client_openxr/src/lib.rs:200:45
|
200 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unreachable_code)]` on by default
Check warning on line 8 in alvr/dashboard/src/dashboard/components/settings_controls/notice.rs
github-actions / clippy
function `notice` is never used
warning: function `notice` is never used
--> alvr/dashboard/src/dashboard/components/settings_controls/notice.rs:8:8
|
8 | pub fn notice(ui: &mut Ui, text: &str) {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 250 in alvr/xtask/src/build.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr/xtask/src/build.rs:250:13
|
250 | &build_layout.openvr_driver_lib_dir(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `build_layout.openvr_driver_lib_dir()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 249 in alvr/xtask/src/build.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr/xtask/src/build.rs:249:13
|
249 | &afs::workspace_dir().join("openvr/bin/linux64/libopenvr_api.so"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::workspace_dir().join("openvr/bin/linux64/libopenvr_api.so")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 187 in alvr/xtask/src/build.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr/xtask/src/build.rs:187:13
|
187 | &build_layout.openvr_driver_lib_dir(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `build_layout.openvr_driver_lib_dir()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 186 in alvr/xtask/src/build.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr/xtask/src/build.rs:186:13
|
186 | &afs::workspace_dir().join("openvr/bin/win64/openvr_api.dll"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::workspace_dir().join("openvr/bin/win64/openvr_api.dll")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 12 in alvr/xtask/src/packaging.rs
github-actions / clippy
function `build_windows_installer` is never used
warning: function `build_windows_installer` is never used
--> alvr/xtask/src/packaging.rs:12:4
|
12 | fn build_windows_installer() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default