Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client_openxr): 🐛 Fix crash with vibration on Focus 3 #2324

Merged
merged 1 commit into from
Aug 12, 2024

fix(client_openxr): :bug: Fix crash with vibration on Focus 3

59683fc
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix(client_openxr): 🐛 Fix crash with vibration on Focus 3 #2324

fix(client_openxr): :bug: Fix crash with vibration on Focus 3
59683fc
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Aug 12, 2024

clippy

16 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 16
Note 0
Help 0

Versions

  • rustc 1.80.1 (3f5fd8dd4 2024-08-06)
  • cargo 1.80.1 (376290515 2024-07-16)
  • clippy 0.1.80 (3f5fd8dd 2024-08-06)

Annotations

Check warning on line 8 in alvr/dashboard/src/dashboard/components/settings_controls/notice.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `notice` is never used

warning: function `notice` is never used
 --> alvr/dashboard/src/dashboard/components/settings_controls/notice.rs:8:8
  |
8 | pub fn notice(ui: &mut Ui, text: &str) {
  |        ^^^^^^
  |
  = note: `#[warn(dead_code)]` on by default

Check warning on line 19 in alvr/client_openxr/src/interaction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `aim_action` and `aim_space` are never read

warning: fields `aim_action` and `aim_space` are never read
  --> alvr/client_openxr/src/interaction.rs:19:9
   |
15 | pub struct HandInteraction {
   |            --------------- fields in this struct
...
19 |     pub aim_action: xr::Action<xr::Posef>,
   |         ^^^^^^^^^^
20 |     pub aim_space: xr::Space,
   |         ^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 186 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> alvr/client_openxr/src/lib.rs:186:9
    |
186 |     let mut stream_config = None::<StreamConfig>;
    |         ----^^^^^^^^^^^^^
    |         |
    |         help: remove this `mut`

Check warning on line 185 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> alvr/client_openxr/src/lib.rs:185:9
    |
185 |     let mut last_lobby_message = String::new();
    |         ----^^^^^^^^^^^^^^^^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 198 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_frame_stream`

warning: unused variable: `xr_frame_stream`
   --> alvr/client_openxr/src/lib.rs:198:51
    |
198 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |                                                   ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`

Check warning on line 198 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_frame_waiter`

warning: unused variable: `xr_frame_waiter`
   --> alvr/client_openxr/src/lib.rs:198:30
    |
198 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |                              ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`

Check warning on line 198 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_session`

warning: unused variable: `xr_session`
   --> alvr/client_openxr/src/lib.rs:198:14
    |
198 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |              ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`

Check warning on line 186 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `stream_config`

warning: unused variable: `stream_config`
   --> alvr/client_openxr/src/lib.rs:186:13
    |
186 |     let mut stream_config = None::<StreamConfig>;
    |             ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream_config`

Check warning on line 185 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `last_lobby_message`

warning: unused variable: `last_lobby_message`
   --> alvr/client_openxr/src/lib.rs:185:13
    |
185 |     let mut last_lobby_message = String::new();
    |             ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 204 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable definition

warning: unreachable definition
   --> alvr/client_openxr/src/lib.rs:204:13
    |
200 |                 .create_session(xr_system, &graphics::session_create_info(&graphics_context))
    |                                             ------------------------------------------------ any code following this expression is unreachable
...
204 |         let xr_context = XrContext {
    |             ^^^^^^^^^^ unreachable definition
    |
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
   --> alvr/client_openxr/src/lib.rs:200:45
    |
200 |                 .create_session(xr_system, &graphics::session_create_info(&graphics_context))
    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: `#[warn(unreachable_code)]` on by default

Check warning on line 479 in alvr/client_core/src/c_api.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item missing indentation

warning: doc list item missing indentation
   --> alvr/client_core/src/c_api.rs:479:5
    |
479 | /// eye_gazes:
    |     ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
    |
479 | ///   eye_gazes:
    |     ++

Check warning on line 476 in alvr/client_core/src/c_api.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item missing indentation

warning: doc list item missing indentation
   --> alvr/client_core/src/c_api.rs:476:5
    |
476 | /// hand_skeleton:
    |     ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
    = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
    |
476 | ///   hand_skeleton:
    |     ++

Check warning on line 72 in alvr/client_core/src/c_api.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `codec` is never read

warning: field `codec` is never read
  --> alvr/client_core/src/c_api.rs:72:9
   |
71 |     DecoderConfig {
   |     ------------- field in this variant
72 |         codec: AlvrCodec,
   |         ^^^^^

Check warning on line 65 in alvr/client_core/src/c_api.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read

warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read
  --> alvr/client_core/src/c_api.rs:65:9
   |
64 |     Haptics {
   |     ------- fields in this variant
65 |         device_id: u64,
   |         ^^^^^^^^^
66 |         duration_s: f32,
   |         ^^^^^^^^^^
67 |         frequency: f32,
   |         ^^^^^^^^^
68 |         amplitude: f32,
   |         ^^^^^^^^^

Check warning on line 58 in alvr/client_core/src/c_api.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `view_width`, `view_height`, `refresh_rate_hint`, and `enable_foveated_encoding` are never read

warning: fields `view_width`, `view_height`, `refresh_rate_hint`, and `enable_foveated_encoding` are never read
  --> alvr/client_core/src/c_api.rs:58:9
   |
57 |     StreamingStarted {
   |     ---------------- fields in this variant
58 |         view_width: u32,
   |         ^^^^^^^^^^
59 |         view_height: u32,
   |         ^^^^^^^^^^^
60 |         refresh_rate_hint: f32,
   |         ^^^^^^^^^^^^^^^^^
61 |         enable_foveated_encoding: bool,
   |         ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 12 in alvr/xtask/src/packaging.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `build_windows_installer` is never used

warning: function `build_windows_installer` is never used
  --> alvr/xtask/src/packaging.rs:12:4
   |
12 | fn build_windows_installer() {
   |    ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default