fix(sockets): 🐛 Ignore error 997 (overlapped IO) (#2522) #882
zmerpAnnotations
135 warnings
|
wiki
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, cmbrose/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
wiki
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, cmbrose/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
function `notice` is never used:
alvr/dashboard/src/dashboard/components/settings_controls/notice.rs#L8
warning: function `notice` is never used
--> alvr/dashboard/src/dashboard/components/settings_controls/notice.rs:8:8
|
8 | pub fn notice(ui: &mut Ui, text: &str) {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
transmute used without annotations:
alvr/client_openxr/src/passthrough.rs#L41
warning: transmute used without annotations
--> alvr/client_openxr/src/passthrough.rs:41:27
|
41 | unsafe { mem::transmute(handle.layer()) }
| ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughHTC, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
|
|
transmute used without annotations:
alvr/client_openxr/src/passthrough.rs#L39
warning: transmute used without annotations
--> alvr/client_openxr/src/passthrough.rs:39:27
|
39 | unsafe { mem::transmute(handle.layer()) }
| ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughFB, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
= note: `#[warn(clippy::missing_transmute_annotations)]` on by default
|
|
fields `aim_action` and `aim_space` are never read:
alvr/client_openxr/src/interaction.rs#L28
warning: fields `aim_action` and `aim_space` are never read
--> alvr/client_openxr/src/interaction.rs:28:9
|
24 | pub struct HandInteraction {
| --------------- fields in this struct
...
28 | pub aim_action: xr::Action<xr::Posef>,
| ^^^^^^^^^^
29 | pub aim_space: xr::Space,
| ^^^^^^^^^
|
|
field `system` is never read:
alvr/client_openxr/src/lib.rs#L92
warning: field `system` is never read
--> alvr/client_openxr/src/lib.rs:92:5
|
90 | pub struct XrContext {
| --------- field in this struct
91 | instance: xr::Instance,
92 | system: xr::SystemId,
| ^^^^^^
|
= note: `XrContext` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
alvr/client_openxr/src/lib.rs#L197
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:197:9
|
197 | let mut parsed_stream_config = None::<ParsedStreamConfig>;
| ----^^^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
alvr/client_openxr/src/lib.rs#L196
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:196:9
|
196 | let mut last_lobby_message = String::new();
| ----^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `xr_frame_stream`:
alvr/client_openxr/src/lib.rs#L209
warning: unused variable: `xr_frame_stream`
--> alvr/client_openxr/src/lib.rs:209:51
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`
|
|
unused variable: `xr_frame_waiter`:
alvr/client_openxr/src/lib.rs#L209
warning: unused variable: `xr_frame_waiter`
--> alvr/client_openxr/src/lib.rs:209:30
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`
|
|
unused variable: `xr_session`:
alvr/client_openxr/src/lib.rs#L209
warning: unused variable: `xr_session`
--> alvr/client_openxr/src/lib.rs:209:14
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`
|
|
unused variable: `parsed_stream_config`:
alvr/client_openxr/src/lib.rs#L197
warning: unused variable: `parsed_stream_config`
--> alvr/client_openxr/src/lib.rs:197:13
|
197 | let mut parsed_stream_config = None::<ParsedStreamConfig>;
| ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parsed_stream_config`
|
|
unused variable: `last_lobby_message`:
alvr/client_openxr/src/lib.rs#L196
warning: unused variable: `last_lobby_message`
--> alvr/client_openxr/src/lib.rs:196:13
|
196 | let mut last_lobby_message = String::new();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable definition:
alvr/client_openxr/src/lib.rs#L215
warning: unreachable definition
--> alvr/client_openxr/src/lib.rs:215:13
|
211 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ------------------------------------------------ any code following this expression is unreachable
...
215 | let xr_context = XrContext {
| ^^^^^^^^^^ unreachable definition
|
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
--> alvr/client_openxr/src/lib.rs:211:45
|
211 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unreachable_code)]` on by default
|
|
using `clone` on type `ViewParams` which implements the `Copy` trait:
alvr/client_mock/src/main.rs#L158
warning: using `clone` on type `ViewParams` which implements the `Copy` trait
--> alvr/client_mock/src/main.rs:158:31
|
158 | context.send_view_params([views_params.clone(), views_params]);
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `views_params`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
this `.filter_map` can be written more simply using `.map`:
alvr/server_core/src/tracking/mod.rs#L526
warning: this `.filter_map` can be written more simply using `.map`
--> alvr/server_core/src/tracking/mod.rs:526:38
|
526 | let device_motions = device_motion_keys
| ______________________________________^
527 | | .iter()
528 | | .filter_map(move |id| {
529 | | Some((
... |
534 | | ))
535 | | })
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
|
|
this `.filter_map` can be written more simply using `.map`:
alvr/server_core/src/tracking/mod.rs#L497
warning: this `.filter_map` can be written more simply using `.map`
--> alvr/server_core/src/tracking/mod.rs:497:38
|
497 | let device_motions = device_motion_keys
| ______________________________________^
498 | | .iter()
499 | | .filter_map(move |id| {
500 | | Some((
... |
505 | | ))
506 | | })
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
= note: `#[warn(clippy::unnecessary_filter_map)]` on by default
|
|
float has excessive precision:
alvr/server_core/src/tracking/vmc.rs#L67
warning: float has excessive precision
--> alvr/server_core/src/tracking/vmc.rs:67:48
|
67 | Quat::from_xyzw(0.70228, -0.08246, 0.7071100, 0.00000),
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
help: consider changing the type or truncating it to
|
67 | Quat::from_xyzw(0.70228, -0.08246, 0.707_11, 0.00000),
| ~~~~~~~~
|
|
float has excessive precision:
alvr/server_core/src/tracking/vmc.rs#L59
warning: float has excessive precision
--> alvr/server_core/src/tracking/vmc.rs:59:58
|
59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.7071100),
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
= note: `#[warn(clippy::excessive_precision)]` on by default
help: consider changing the type or truncating it to
|
59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.707_11),
| ~~~~~~~~
|
|
casting to the same type is unnecessary (`f32` -> `f32`):
alvr/server_core/src/bitrate.rs#L133
warning: casting to the same type is unnecessary (`f32` -> `f32`)
--> alvr/server_core/src/bitrate.rs:133:25
|
133 | self.packet_bytes_average.get_average() as f32,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.packet_bytes_average.get_average()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
returning the result of a `let` binding from a block:
alvr/client_core/src/lib.rs#L364
warning: returning the result of a `let` binding from a block
--> alvr/client_core/src/lib.rs:364:9
|
353 | / let view_params = [
354 | | ViewParams {
355 | | pose: head_pose * view_params[0].pose,
356 | | fov: view_params[0].fov,
... |
361 | | },
362 | | ];
| |__________- unnecessary `let` binding
363 |
364 | view_params
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
353 ~
354 |
355 ~ [
356 + ViewParams {
357 + pose: head_pose * view_params[0].pose,
358 + fov: view_params[0].fov,
359 + },
360 + ViewParams {
361 + pose: head_pose * view_params[1].pose,
362 + fov: view_params[1].fov,
363 + },
364 + ]
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
alvr/client_core/src/lib.rs#L312
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr/client_core/src/lib.rs:312:19
|
312 | callback: Box<dyn FnMut(Duration, &[u8]) -> bool + Send>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
alvr/client_core/src/connection.rs#L65
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr/client_core/src/connection.rs:65:27
|
65 | pub decoder_callback: Mutex<Option<Box<dyn FnMut(Duration, &[u8]) -> bool + Send>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
variants `Float`, `Int32`, `Int64`, and `String` are never constructed:
alvr/client_core/src/c_api.rs#L839
warning: variants `Float`, `Int32`, `Int64`, and `String` are never constructed
--> alvr/client_core/src/c_api.rs:839:5
|
838 | pub enum AlvrMediacodecPropType {
| ---------------------- variants in this enum
839 | Float,
| ^^^^^
840 | Int32,
| ^^^^^
841 | Int64,
| ^^^^^
842 | String,
| ^^^^^^
|
|
field `codec` is never read:
alvr/client_core/src/c_api.rs#L78
warning: field `codec` is never read
--> alvr/client_core/src/c_api.rs:78:9
|
77 | DecoderConfig {
| ------------- field in this variant
78 | codec: AlvrCodec,
| ^^^^^
|
|
fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read:
alvr/client_core/src/c_api.rs#L71
warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read
--> alvr/client_core/src/c_api.rs:71:9
|
70 | Haptics {
| ------- fields in this variant
71 | device_id: u64,
| ^^^^^^^^^
72 | duration_s: f32,
| ^^^^^^^^^^
73 | frequency: f32,
| ^^^^^^^^^
74 | amplitude: f32,
| ^^^^^^^^^
|
|
fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read:
alvr/client_core/src/c_api.rs#L62
warning: fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read
--> alvr/client_core/src/c_api.rs:62:9
|
61 | StreamingStarted {
| ---------------- fields in this variant
62 | view_width: u32,
| ^^^^^^^^^^
63 | view_height: u32,
| ^^^^^^^^^^^
64 | refresh_rate_hint: f32,
| ^^^^^^^^^^^^^^^^^
65 | encoding_gamma: f32,
| ^^^^^^^^^^^^^^
66 | enable_foveated_encoding: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^
67 | enable_hdr: bool,
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
fields `remote` and `serial` are never read:
alvr/adb/src/parse.rs#L126
warning: fields `remote` and `serial` are never read
--> alvr/adb/src/parse.rs:126:9
|
124 | pub struct ForwardedPorts {
| -------------- fields in this struct
125 | pub local: u16,
126 | pub remote: u16,
| ^^^^^^
127 | pub serial: String,
| ^^^^^^
|
= note: `ForwardedPorts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read:
alvr/adb/src/parse.rs#L75
warning: fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read
--> alvr/adb/src/parse.rs:75:9
|
74 | pub struct Device {
| ------ fields in this struct
75 | pub connection_state: Option<ConnectionState>,
| ^^^^^^^^^^^^^^^^
76 | pub device: Option<String>,
| ^^^^^^
77 | pub model: Option<String>,
| ^^^^^
78 | pub product: Option<String>,
| ^^^^^^^
79 | pub serial: Option<String>,
80 | pub transport_type: Option<TransportType>,
| ^^^^^^^^^^^^^^
|
= note: `Device` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
function `uninstall_package` is never used:
alvr/adb/src/commands.rs#L229
warning: function `uninstall_package` is never used
--> alvr/adb/src/commands.rs:229:8
|
229 | pub fn uninstall_package(adb_path: &str, device_serial: &str, application_id: &str) -> Result<()> {
| ^^^^^^^^^^^^^^^^^
|
|
function `install_package` is never used:
alvr/adb/src/commands.rs#L207
warning: function `install_package` is never used
--> alvr/adb/src/commands.rs:207:8
|
207 | pub fn install_package(adb_path: &str, device_serial: &str, apk_path: &str) -> Result<()> {
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
function `build_windows_installer` is never used:
alvr/xtask/src/packaging.rs#L21
warning: function `build_windows_installer` is never used
--> alvr/xtask/src/packaging.rs:21:4
|
21 | fn build_windows_installer() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `self::VkLoaderFeastureFlagBits as VkLoaderFlagBits`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L36318
warning: unused import: `self::VkLoaderFeastureFlagBits as VkLoaderFlagBits`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:36318:9
|
36318 | pub use self::VkLoaderFeastureFlagBits as VkLoaderFlagBits;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L32593
warning: unused import: `self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:32593:9
|
32593 | pub use self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L30396
warning: unused import: `self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:30396:9
|
30396 | pub use self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L28983
warning: unused import: `self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:28983:9
|
28983 | pub use self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L28509
warning: unused import: `self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:28509:9
|
28509 | pub use self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L27500
warning: unused import: `self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:27500:9
|
27500 | pub use self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L27483
warning: unused import: `self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:27483:9
|
27483 | pub use self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L27462
warning: unused import: `self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:27462:9
|
27462 | pub use self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L27445
warning: unused import: `self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:27445:9
|
27445 | pub use self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkGeometryTypeKHR as VkGeometryTypeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L27415
warning: unused import: `self::VkGeometryTypeKHR as VkGeometryTypeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:27415:9
|
27415 | pub use self::VkGeometryTypeKHR as VkGeometryTypeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L27407
warning: unused import: `self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:27407:9
|
27407 | pub use self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L27066
warning: unused import: `self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:27066:9
|
27066 | pub use self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerReductionMode as VkSamplerReductionModeEXT`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L26044
warning: unused import: `self::VkSamplerReductionMode as VkSamplerReductionModeEXT`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:26044:9
|
26044 | pub use self::VkSamplerReductionMode as VkSamplerReductionModeEXT;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSubmitFlagBits as VkSubmitFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L22789
warning: unused import: `self::VkSubmitFlagBits as VkSubmitFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:22789:9
|
22789 | pub use self::VkSubmitFlagBits as VkSubmitFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21922
warning: unused import: `self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21922:9
|
21922 | pub use self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreType as VkSemaphoreTypeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21921
warning: unused import: `self::VkSemaphoreType as VkSemaphoreTypeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21921:9
|
21921 | pub use self::VkSemaphoreType as VkSemaphoreTypeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21916
warning: unused import: `self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21916:9
|
21916 | pub use self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21914
warning: unused import: `self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21914:9
|
21914 | pub use self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDriverId as VkDriverIdKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21911
warning: unused import: `self::VkDriverId as VkDriverIdKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21911:9
|
21911 | pub use self::VkDriverId as VkDriverIdKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21630
warning: unused import: `self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21630:9
|
21630 | pub use self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21629
warning: unused import: `self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21629:9
|
21629 | pub use self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkChromaLocation as VkChromaLocationKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21628
warning: unused import: `self::VkChromaLocation as VkChromaLocationKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21628:9
|
21628 | pub use self::VkChromaLocation as VkChromaLocationKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21246
warning: unused import: `self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21246:9
|
21246 | pub use self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPointClippingBehavior as VkPointClippingBehaviorKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L21245
warning: unused import: `self::VkPointClippingBehavior as VkPointClippingBehaviorKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:21245:9
|
21245 | pub use self::VkPointClippingBehavior as VkPointClippingBehaviorKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20771
warning: unused import: `self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20771:9
|
20771 | pub use self::VkFenceImportFlagBits as VkFenceImportFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20753
warning: unused import: `self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20753:9
|
20753 | pub use self::VkExternalFenceFeatureFlagBits as VkExternalFenceFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20751
warning: unused import: `self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20751:9
|
20751 | pub use self::VkExternalFenceHandleTypeFlagBits as VkExternalFenceHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20597
warning: unused import: `self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20597:9
|
20597 | pub use self::VkDescriptorUpdateTemplateType as VkDescriptorUpdateTemplateTypeKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20354
warning: unused import: `self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20354:9
|
20354 | pub use self::VkSemaphoreImportFlagBits as VkSemaphoreImportFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20336
warning: unused import: `self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20336:9
|
20336 | pub use self::VkExternalSemaphoreFeatureFlagBits as VkExternalSemaphoreFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20334
warning: unused import: `self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20334:9
|
20334 | pub use self::VkExternalSemaphoreHandleTypeFlagBits as VkExternalSemaphoreHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20190
warning: unused import: `self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20190:9
|
20190 | pub use self::VkExternalMemoryFeatureFlagBits as VkExternalMemoryFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20188
warning: unused import: `self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20188:9
|
20188 | pub use self::VkExternalMemoryHandleTypeFlagBits as VkExternalMemoryHandleTypeFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20103
warning: unused import: `self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20103:9
|
20103 | pub use self::VkMemoryAllocateFlagBits as VkMemoryAllocateFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L20101
warning: unused import: `self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:20101:9
|
20101 | pub use self::VkPeerMemoryFeatureFlagBits as VkPeerMemoryFeatureFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `self::VkRenderingFlagBits as VkRenderingFlagBitsKHR`:
/home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs#L19827
warning: unused import: `self::VkRenderingFlagBits as VkRenderingFlagBitsKHR`
--> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-d744ae80ee4566da/out/layer_bindings.rs:19827:9
|
19827 | pub use self::VkRenderingFlagBits as VkRenderingFlagBitsKHR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
function `notice` is never used:
alvr/dashboard/src/dashboard/components/settings_controls/notice.rs#L8
warning: function `notice` is never used
--> alvr/dashboard/src/dashboard/components/settings_controls/notice.rs:8:8
|
8 | pub fn notice(ui: &mut Ui, text: &str) {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
using `clone` on type `ViewParams` which implements the `Copy` trait:
alvr/client_mock/src/main.rs#L158
warning: using `clone` on type `ViewParams` which implements the `Copy` trait
--> alvr/client_mock/src/main.rs:158:31
|
158 | context.send_view_params([views_params.clone(), views_params]);
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `views_params`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
transmute used without annotations:
alvr/client_openxr/src/passthrough.rs#L41
warning: transmute used without annotations
--> alvr/client_openxr/src/passthrough.rs:41:27
|
41 | unsafe { mem::transmute(handle.layer()) }
| ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughHTC, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
|
|
transmute used without annotations:
alvr/client_openxr/src/passthrough.rs#L39
warning: transmute used without annotations
--> alvr/client_openxr/src/passthrough.rs:39:27
|
39 | unsafe { mem::transmute(handle.layer()) }
| ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughFB, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
= note: `#[warn(clippy::missing_transmute_annotations)]` on by default
|
|
fields `aim_action` and `aim_space` are never read:
alvr/client_openxr/src/interaction.rs#L28
warning: fields `aim_action` and `aim_space` are never read
--> alvr/client_openxr/src/interaction.rs:28:9
|
24 | pub struct HandInteraction {
| --------------- fields in this struct
...
28 | pub aim_action: xr::Action<xr::Posef>,
| ^^^^^^^^^^
29 | pub aim_space: xr::Space,
| ^^^^^^^^^
|
|
field `system` is never read:
alvr/client_openxr/src/lib.rs#L92
warning: field `system` is never read
--> alvr/client_openxr/src/lib.rs:92:5
|
90 | pub struct XrContext {
| --------- field in this struct
91 | instance: xr::Instance,
92 | system: xr::SystemId,
| ^^^^^^
|
= note: `XrContext` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
alvr/client_openxr/src/lib.rs#L197
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:197:9
|
197 | let mut parsed_stream_config = None::<ParsedStreamConfig>;
| ----^^^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
alvr/client_openxr/src/lib.rs#L196
warning: variable does not need to be mutable
--> alvr/client_openxr/src/lib.rs:196:9
|
196 | let mut last_lobby_message = String::new();
| ----^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `xr_frame_stream`:
alvr/client_openxr/src/lib.rs#L209
warning: unused variable: `xr_frame_stream`
--> alvr/client_openxr/src/lib.rs:209:51
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`
|
|
unused variable: `xr_frame_waiter`:
alvr/client_openxr/src/lib.rs#L209
warning: unused variable: `xr_frame_waiter`
--> alvr/client_openxr/src/lib.rs:209:30
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`
|
|
unused variable: `xr_session`:
alvr/client_openxr/src/lib.rs#L209
warning: unused variable: `xr_session`
--> alvr/client_openxr/src/lib.rs:209:14
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`
|
|
unused variable: `parsed_stream_config`:
alvr/client_openxr/src/lib.rs#L197
warning: unused variable: `parsed_stream_config`
--> alvr/client_openxr/src/lib.rs:197:13
|
197 | let mut parsed_stream_config = None::<ParsedStreamConfig>;
| ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parsed_stream_config`
|
|
unused variable: `last_lobby_message`:
alvr/client_openxr/src/lib.rs#L196
warning: unused variable: `last_lobby_message`
--> alvr/client_openxr/src/lib.rs:196:13
|
196 | let mut last_lobby_message = String::new();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable definition:
alvr/client_openxr/src/lib.rs#L215
warning: unreachable definition
--> alvr/client_openxr/src/lib.rs:215:13
|
211 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ------------------------------------------------ any code following this expression is unreachable
...
215 | let xr_context = XrContext {
| ^^^^^^^^^^ unreachable definition
|
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
--> alvr/client_openxr/src/lib.rs:211:45
|
211 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unreachable_code)]` on by default
|
|
this `.filter_map` can be written more simply using `.map`:
alvr/server_core/src/tracking/mod.rs#L526
warning: this `.filter_map` can be written more simply using `.map`
--> alvr/server_core/src/tracking/mod.rs:526:38
|
526 | let device_motions = device_motion_keys
| ______________________________________^
527 | | .iter()
528 | | .filter_map(move |id| {
529 | | Some((
... |
534 | | ))
535 | | })
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
|
|
this `.filter_map` can be written more simply using `.map`:
alvr/server_core/src/tracking/mod.rs#L497
warning: this `.filter_map` can be written more simply using `.map`
--> alvr/server_core/src/tracking/mod.rs:497:38
|
497 | let device_motions = device_motion_keys
| ______________________________________^
498 | | .iter()
499 | | .filter_map(move |id| {
500 | | Some((
... |
505 | | ))
506 | | })
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
= note: `#[warn(clippy::unnecessary_filter_map)]` on by default
|
|
float has excessive precision:
alvr/server_core/src/tracking/vmc.rs#L67
warning: float has excessive precision
--> alvr/server_core/src/tracking/vmc.rs:67:48
|
67 | Quat::from_xyzw(0.70228, -0.08246, 0.7071100, 0.00000),
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
help: consider changing the type or truncating it to
|
67 | Quat::from_xyzw(0.70228, -0.08246, 0.707_11, 0.00000),
| ~~~~~~~~
|
|
float has excessive precision:
alvr/server_core/src/tracking/vmc.rs#L59
warning: float has excessive precision
--> alvr/server_core/src/tracking/vmc.rs:59:58
|
59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.7071100),
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
= note: `#[warn(clippy::excessive_precision)]` on by default
help: consider changing the type or truncating it to
|
59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.707_11),
| ~~~~~~~~
|
|
casting to the same type is unnecessary (`f32` -> `f32`):
alvr/server_core/src/bitrate.rs#L133
warning: casting to the same type is unnecessary (`f32` -> `f32`)
--> alvr/server_core/src/bitrate.rs:133:25
|
133 | self.packet_bytes_average.get_average() as f32,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.packet_bytes_average.get_average()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
returning the result of a `let` binding from a block:
alvr/client_core/src/lib.rs#L364
warning: returning the result of a `let` binding from a block
--> alvr/client_core/src/lib.rs:364:9
|
353 | / let view_params = [
354 | | ViewParams {
355 | | pose: head_pose * view_params[0].pose,
356 | | fov: view_params[0].fov,
... |
361 | | },
362 | | ];
| |__________- unnecessary `let` binding
363 |
364 | view_params
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
353 ~
354 |
355 ~ [
356 + ViewParams {
357 + pose: head_pose * view_params[0].pose,
358 + fov: view_params[0].fov,
359 + },
360 + ViewParams {
361 + pose: head_pose * view_params[1].pose,
362 + fov: view_params[1].fov,
363 + },
364 + ]
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
alvr/client_core/src/lib.rs#L312
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr/client_core/src/lib.rs:312:19
|
312 | callback: Box<dyn FnMut(Duration, &[u8]) -> bool + Send>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
alvr/client_core/src/connection.rs#L65
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr/client_core/src/connection.rs:65:27
|
65 | pub decoder_callback: Mutex<Option<Box<dyn FnMut(Duration, &[u8]) -> bool + Send>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
variants `Float`, `Int32`, `Int64`, and `String` are never constructed:
alvr/client_core/src/c_api.rs#L839
warning: variants `Float`, `Int32`, `Int64`, and `String` are never constructed
--> alvr/client_core/src/c_api.rs:839:5
|
838 | pub enum AlvrMediacodecPropType {
| ---------------------- variants in this enum
839 | Float,
| ^^^^^
840 | Int32,
| ^^^^^
841 | Int64,
| ^^^^^
842 | String,
| ^^^^^^
|
|
field `codec` is never read:
alvr/client_core/src/c_api.rs#L78
warning: field `codec` is never read
--> alvr/client_core/src/c_api.rs:78:9
|
77 | DecoderConfig {
| ------------- field in this variant
78 | codec: AlvrCodec,
| ^^^^^
|
|
fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read:
alvr/client_core/src/c_api.rs#L71
warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read
--> alvr/client_core/src/c_api.rs:71:9
|
70 | Haptics {
| ------- fields in this variant
71 | device_id: u64,
| ^^^^^^^^^
72 | duration_s: f32,
| ^^^^^^^^^^
73 | frequency: f32,
| ^^^^^^^^^
74 | amplitude: f32,
| ^^^^^^^^^
|
|
fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read:
alvr/client_core/src/c_api.rs#L62
warning: fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read
--> alvr/client_core/src/c_api.rs:62:9
|
61 | StreamingStarted {
| ---------------- fields in this variant
62 | view_width: u32,
| ^^^^^^^^^^
63 | view_height: u32,
| ^^^^^^^^^^^
64 | refresh_rate_hint: f32,
| ^^^^^^^^^^^^^^^^^
65 | encoding_gamma: f32,
| ^^^^^^^^^^^^^^
66 | enable_foveated_encoding: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^
67 | enable_hdr: bool,
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
fields `remote` and `serial` are never read:
alvr/adb/src/parse.rs#L126
warning: fields `remote` and `serial` are never read
--> alvr/adb/src/parse.rs:126:9
|
124 | pub struct ForwardedPorts {
| -------------- fields in this struct
125 | pub local: u16,
126 | pub remote: u16,
| ^^^^^^
127 | pub serial: String,
| ^^^^^^
|
= note: `ForwardedPorts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read:
alvr/adb/src/parse.rs#L75
warning: fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read
--> alvr/adb/src/parse.rs:75:9
|
74 | pub struct Device {
| ------ fields in this struct
75 | pub connection_state: Option<ConnectionState>,
| ^^^^^^^^^^^^^^^^
76 | pub device: Option<String>,
| ^^^^^^
77 | pub model: Option<String>,
| ^^^^^
78 | pub product: Option<String>,
| ^^^^^^^
79 | pub serial: Option<String>,
80 | pub transport_type: Option<TransportType>,
| ^^^^^^^^^^^^^^
|
= note: `Device` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
function `uninstall_package` is never used:
alvr/adb/src/commands.rs#L229
warning: function `uninstall_package` is never used
--> alvr/adb/src/commands.rs:229:8
|
229 | pub fn uninstall_package(adb_path: &str, device_serial: &str, application_id: &str) -> Result<()> {
| ^^^^^^^^^^^^^^^^^
|
|
function `install_package` is never used:
alvr/adb/src/commands.rs#L207
warning: function `install_package` is never used
--> alvr/adb/src/commands.rs:207:8
|
207 | pub fn install_package(adb_path: &str, device_serial: &str, apk_path: &str) -> Result<()> {
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
this returns a `Result<_, ()>`:
alvr/audio/src/linux.rs#L220
warning: this returns a `Result<_, ()>`
--> alvr/audio/src/linux.rs:220:1
|
220 | / pub fn record_audio_blocking_pipewire(
221 | | is_running: Arc<dyn Fn() -> bool + Send + Sync>,
222 | | sender: StreamSender<()>,
223 | | channels_count: u16,
224 | | sample_rate: u32,
225 | | ) -> Result<(), ()> {
| |___________________^
|
= help: use a custom `Error` type instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
= note: `#[warn(clippy::result_unit_err)]` on by default
|
|
function `build_windows_installer` is never used:
alvr/xtask/src/packaging.rs#L21
warning: function `build_windows_installer` is never used
--> alvr/xtask/src/packaging.rs:21:4
|
21 | fn build_windows_installer() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
function `notice` is never used:
alvr\dashboard\src\dashboard\components\settings_controls\notice.rs#L8
warning: function `notice` is never used
--> alvr\dashboard\src\dashboard\components\settings_controls\notice.rs:8:8
|
8 | pub fn notice(ui: &mut Ui, text: &str) {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
using `clone` on type `ViewParams` which implements the `Copy` trait:
alvr\client_mock\src/main.rs#L158
warning: using `clone` on type `ViewParams` which implements the `Copy` trait
--> alvr\client_mock\src/main.rs:158:31
|
158 | context.send_view_params([views_params.clone(), views_params]);
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `views_params`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
transmute used without annotations:
alvr\client_openxr\src\passthrough.rs#L41
warning: transmute used without annotations
--> alvr\client_openxr\src\passthrough.rs:41:27
|
41 | unsafe { mem::transmute(handle.layer()) }
| ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughHTC, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
|
|
transmute used without annotations:
alvr\client_openxr\src\passthrough.rs#L39
warning: transmute used without annotations
--> alvr\client_openxr\src\passthrough.rs:39:27
|
39 | unsafe { mem::transmute(handle.layer()) }
| ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughFB, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
= note: `#[warn(clippy::missing_transmute_annotations)]` on by default
|
|
fields `aim_action` and `aim_space` are never read:
alvr\client_openxr\src\interaction.rs#L28
warning: fields `aim_action` and `aim_space` are never read
--> alvr\client_openxr\src\interaction.rs:28:9
|
24 | pub struct HandInteraction {
| --------------- fields in this struct
...
28 | pub aim_action: xr::Action<xr::Posef>,
| ^^^^^^^^^^
29 | pub aim_space: xr::Space,
| ^^^^^^^^^
|
|
field `system` is never read:
alvr\client_openxr\src\lib.rs#L92
warning: field `system` is never read
--> alvr\client_openxr\src\lib.rs:92:5
|
90 | pub struct XrContext {
| --------- field in this struct
91 | instance: xr::Instance,
92 | system: xr::SystemId,
| ^^^^^^
|
= note: `XrContext` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
alvr\client_openxr\src\lib.rs#L197
warning: variable does not need to be mutable
--> alvr\client_openxr\src\lib.rs:197:9
|
197 | let mut parsed_stream_config = None::<ParsedStreamConfig>;
| ----^^^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
|
variable does not need to be mutable:
alvr\client_openxr\src\lib.rs#L196
warning: variable does not need to be mutable
--> alvr\client_openxr\src\lib.rs:196:9
|
196 | let mut last_lobby_message = String::new();
| ----^^^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused variable: `xr_frame_stream`:
alvr\client_openxr\src\lib.rs#L209
warning: unused variable: `xr_frame_stream`
--> alvr\client_openxr\src\lib.rs:209:51
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`
|
|
unused variable: `xr_frame_waiter`:
alvr\client_openxr\src\lib.rs#L209
warning: unused variable: `xr_frame_waiter`
--> alvr\client_openxr\src\lib.rs:209:30
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`
|
|
unused variable: `xr_session`:
alvr\client_openxr\src\lib.rs#L209
warning: unused variable: `xr_session`
--> alvr\client_openxr\src\lib.rs:209:14
|
209 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`
|
|
unused variable: `parsed_stream_config`:
alvr\client_openxr\src\lib.rs#L197
warning: unused variable: `parsed_stream_config`
--> alvr\client_openxr\src\lib.rs:197:13
|
197 | let mut parsed_stream_config = None::<ParsedStreamConfig>;
| ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parsed_stream_config`
|
|
unused variable: `last_lobby_message`:
alvr\client_openxr\src\lib.rs#L196
warning: unused variable: `last_lobby_message`
--> alvr\client_openxr\src\lib.rs:196:13
|
196 | let mut last_lobby_message = String::new();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unreachable definition:
alvr\client_openxr\src\lib.rs#L215
warning: unreachable definition
--> alvr\client_openxr\src\lib.rs:215:13
|
211 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ------------------------------------------------ any code following this expression is unreachable
...
215 | let xr_context = XrContext {
| ^^^^^^^^^^ unreachable definition
|
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
--> alvr\client_openxr\src\lib.rs:211:45
|
211 | .create_session(xr_system, &graphics::session_create_info(&graphics_context))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(unreachable_code)]` on by default
|
|
this `.filter_map` can be written more simply using `.map`:
alvr\server_core\src\tracking\mod.rs#L526
warning: this `.filter_map` can be written more simply using `.map`
--> alvr\server_core\src\tracking\mod.rs:526:38
|
526 | let device_motions = device_motion_keys
| ______________________________________^
527 | | .iter()
528 | | .filter_map(move |id| {
529 | | Some((
... |
534 | | ))
535 | | })
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
|
|
this `.filter_map` can be written more simply using `.map`:
alvr\server_core\src\tracking\mod.rs#L497
warning: this `.filter_map` can be written more simply using `.map`
--> alvr\server_core\src\tracking\mod.rs:497:38
|
497 | let device_motions = device_motion_keys
| ______________________________________^
498 | | .iter()
499 | | .filter_map(move |id| {
500 | | Some((
... |
505 | | ))
506 | | })
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
= note: `#[warn(clippy::unnecessary_filter_map)]` on by default
|
|
float has excessive precision:
alvr\server_core\src\tracking\vmc.rs#L67
warning: float has excessive precision
--> alvr\server_core\src\tracking\vmc.rs:67:48
|
67 | Quat::from_xyzw(0.70228, -0.08246, 0.7071100, 0.00000),
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
help: consider changing the type or truncating it to
|
67 | Quat::from_xyzw(0.70228, -0.08246, 0.707_11, 0.00000),
| ~~~~~~~~
|
|
float has excessive precision:
alvr\server_core\src\tracking\vmc.rs#L59
warning: float has excessive precision
--> alvr\server_core\src\tracking\vmc.rs:59:58
|
59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.7071100),
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
= note: `#[warn(clippy::excessive_precision)]` on by default
help: consider changing the type or truncating it to
|
59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.707_11),
| ~~~~~~~~
|
|
casting to the same type is unnecessary (`f32` -> `f32`):
alvr\server_core\src\bitrate.rs#L133
warning: casting to the same type is unnecessary (`f32` -> `f32`)
--> alvr\server_core\src\bitrate.rs:133:25
|
133 | self.packet_bytes_average.get_average() as f32,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.packet_bytes_average.get_average()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
returning the result of a `let` binding from a block:
alvr\client_core\src\lib.rs#L364
warning: returning the result of a `let` binding from a block
--> alvr\client_core\src\lib.rs:364:9
|
353 | / let view_params = [
354 | | ViewParams {
355 | | pose: head_pose * view_params[0].pose,
356 | | fov: view_params[0].fov,
... |
361 | | },
362 | | ];
| |__________- unnecessary `let` binding
363 |
364 | view_params
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
353 ~
354 |
355 ~ [
356 + ViewParams {
357 + pose: head_pose * view_params[0].pose,
358 + fov: view_params[0].fov,
359 + },
360 + ViewParams {
361 + pose: head_pose * view_params[1].pose,
362 + fov: view_params[1].fov,
363 + },
364 + ]
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
alvr\client_core\src\lib.rs#L312
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr\client_core\src\lib.rs:312:19
|
312 | callback: Box<dyn FnMut(Duration, &[u8]) -> bool + Send>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
alvr\client_core\src\connection.rs#L65
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr\client_core\src\connection.rs:65:27
|
65 | pub decoder_callback: Mutex<Option<Box<dyn FnMut(Duration, &[u8]) -> bool + Send>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
fields `adapter` and `dummy_surface` are never read:
alvr\client_core\src\graphics\mod.rs#L167
warning: fields `adapter` and `dummy_surface` are never read
--> alvr\client_core\src\graphics\mod.rs:167:5
|
165 | pub struct GraphicsContext {
| --------------- fields in this struct
166 | _instance: Instance,
167 | adapter: Adapter,
| ^^^^^^^
...
174 | dummy_surface: egl::Surface,
| ^^^^^^^^^^^^^
|
|
variants `Float`, `Int32`, `Int64`, and `String` are never constructed:
alvr\client_core\src\c_api.rs#L839
warning: variants `Float`, `Int32`, `Int64`, and `String` are never constructed
--> alvr\client_core\src\c_api.rs:839:5
|
838 | pub enum AlvrMediacodecPropType {
| ---------------------- variants in this enum
839 | Float,
| ^^^^^
840 | Int32,
| ^^^^^
841 | Int64,
| ^^^^^
842 | String,
| ^^^^^^
|
|
field `codec` is never read:
alvr\client_core\src\c_api.rs#L78
warning: field `codec` is never read
--> alvr\client_core\src\c_api.rs:78:9
|
77 | DecoderConfig {
| ------------- field in this variant
78 | codec: AlvrCodec,
| ^^^^^
|
|
fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read:
alvr\client_core\src\c_api.rs#L71
warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read
--> alvr\client_core\src\c_api.rs:71:9
|
70 | Haptics {
| ------- fields in this variant
71 | device_id: u64,
| ^^^^^^^^^
72 | duration_s: f32,
| ^^^^^^^^^^
73 | frequency: f32,
| ^^^^^^^^^
74 | amplitude: f32,
| ^^^^^^^^^
|
|
fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read:
alvr\client_core\src\c_api.rs#L62
warning: fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read
--> alvr\client_core\src\c_api.rs:62:9
|
61 | StreamingStarted {
| ---------------- fields in this variant
62 | view_width: u32,
| ^^^^^^^^^^
63 | view_height: u32,
| ^^^^^^^^^^^
64 | refresh_rate_hint: f32,
| ^^^^^^^^^^^^^^^^^
65 | encoding_gamma: f32,
| ^^^^^^^^^^^^^^
66 | enable_foveated_encoding: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^
67 | enable_hdr: bool,
| ^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused imports: `InstanceDescriptor` and `InstanceFlags`:
alvr\client_core\src\graphics\mod.rs#L15
warning: unused imports: `InstanceDescriptor` and `InstanceFlags`
--> alvr\client_core\src\graphics\mod.rs:15:42
|
15 | Adapter, Device, Extent3d, Instance, InstanceDescriptor, InstanceFlags, Queue, Texture,
| ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^
|
|
unused import: `mem`:
alvr\client_core\src\graphics\mod.rs#L12
warning: unused import: `mem`
--> alvr\client_core\src\graphics\mod.rs:12:24
|
12 | use std::{ffi::c_void, mem, num::NonZeroU32, ptr};
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
fields `remote` and `serial` are never read:
alvr\adb\src\parse.rs#L126
warning: fields `remote` and `serial` are never read
--> alvr\adb\src\parse.rs:126:9
|
124 | pub struct ForwardedPorts {
| -------------- fields in this struct
125 | pub local: u16,
126 | pub remote: u16,
| ^^^^^^
127 | pub serial: String,
| ^^^^^^
|
= note: `ForwardedPorts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read:
alvr\adb\src\parse.rs#L75
warning: fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read
--> alvr\adb\src\parse.rs:75:9
|
74 | pub struct Device {
| ------ fields in this struct
75 | pub connection_state: Option<ConnectionState>,
| ^^^^^^^^^^^^^^^^
76 | pub device: Option<String>,
| ^^^^^^
77 | pub model: Option<String>,
| ^^^^^
78 | pub product: Option<String>,
| ^^^^^^^
79 | pub serial: Option<String>,
80 | pub transport_type: Option<TransportType>,
| ^^^^^^^^^^^^^^
|
= note: `Device` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
function `uninstall_package` is never used:
alvr\adb\src\commands.rs#L229
warning: function `uninstall_package` is never used
--> alvr\adb\src\commands.rs:229:8
|
229 | pub fn uninstall_package(adb_path: &str, device_serial: &str, application_id: &str) -> Result<()> {
| ^^^^^^^^^^^^^^^^^
|
|
function `install_package` is never used:
alvr\adb\src\commands.rs#L207
warning: function `install_package` is never used
--> alvr\adb\src\commands.rs:207:8
|
207 | pub fn install_package(adb_path: &str, device_serial: &str, apk_path: &str) -> Result<()> {
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
function `build_windows_installer` is never used:
alvr\xtask\src\packaging.rs#L21
warning: function `build_windows_installer` is never used
--> alvr\xtask\src\packaging.rs:21:4
|
21 | fn build_windows_installer() {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|