From 3f626e9f9b1ce9131cf2d9feb2abcce689a1c275 Mon Sep 17 00:00:00 2001 From: Nate Parsons Date: Tue, 13 Feb 2024 13:55:34 -0600 Subject: [PATCH 1/4] fix alert --- .github/workflows/tests_with_woodwork_main_branch.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests_with_woodwork_main_branch.yaml b/.github/workflows/tests_with_woodwork_main_branch.yaml index 1fdfa47f11..1a3f17d642 100644 --- a/.github/workflows/tests_with_woodwork_main_branch.yaml +++ b/.github/workflows/tests_with_woodwork_main_branch.yaml @@ -67,7 +67,7 @@ jobs: if: ${{ always() }} steps: - name: Send Slack alert if failure - if: ${{ needs.unit_tests_woodwork_main.result != 'success' }} + if: ${{ needs.tests_woodwork_main.result != 'success' }} id: slack uses: slackapi/slack-github-action@v1 with: From 311c63c32641835d8e6216738ef71646315b4df0 Mon Sep 17 00:00:00 2001 From: Nate Parsons Date: Tue, 13 Feb 2024 13:57:04 -0600 Subject: [PATCH 2/4] update release notes --- docs/source/release_notes.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/source/release_notes.rst b/docs/source/release_notes.rst index 843edf0271..edeb9e7456 100644 --- a/docs/source/release_notes.rst +++ b/docs/source/release_notes.rst @@ -18,6 +18,7 @@ Future Release * Update dependency checkers and tests to include Dask (:pr:`2658`) * Fix the tests that run with Woodwork main so they can be triggered (:pr:`2657`) * Fix minimum dependency checker action (:pr:`2664`) + * Fix Slack alert for tests with Woodwork main branch (:pr:`2668`) Thanks to the following people for contributing to this release: From 2e3c5623f99b6ccc9249e60949de4061e489d5ea Mon Sep 17 00:00:00 2001 From: Nate Parsons Date: Tue, 13 Feb 2024 14:30:46 -0600 Subject: [PATCH 3/4] try another fix --- .github/workflows/tests_with_woodwork_main_branch.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests_with_woodwork_main_branch.yaml b/.github/workflows/tests_with_woodwork_main_branch.yaml index 1a3f17d642..fb7a5110b8 100644 --- a/.github/workflows/tests_with_woodwork_main_branch.yaml +++ b/.github/workflows/tests_with_woodwork_main_branch.yaml @@ -67,7 +67,7 @@ jobs: if: ${{ always() }} steps: - name: Send Slack alert if failure - if: ${{ needs.tests_woodwork_main.result != 'success' }} + if: always() && needs.tests_woodwork_main.result != 'success' id: slack uses: slackapi/slack-github-action@v1 with: From ca3161ca7f220c5a44a9e0682eae866ae6c31253 Mon Sep 17 00:00:00 2001 From: Nate Parsons Date: Tue, 13 Feb 2024 14:57:02 -0600 Subject: [PATCH 4/4] revert change --- .github/workflows/tests_with_woodwork_main_branch.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests_with_woodwork_main_branch.yaml b/.github/workflows/tests_with_woodwork_main_branch.yaml index fb7a5110b8..1a3f17d642 100644 --- a/.github/workflows/tests_with_woodwork_main_branch.yaml +++ b/.github/workflows/tests_with_woodwork_main_branch.yaml @@ -67,7 +67,7 @@ jobs: if: ${{ always() }} steps: - name: Send Slack alert if failure - if: always() && needs.tests_woodwork_main.result != 'success' + if: ${{ needs.tests_woodwork_main.result != 'success' }} id: slack uses: slackapi/slack-github-action@v1 with: