Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests in test_deep_feature_synthesis.py #1305

Closed
thehomebrewnerd opened this issue Jan 12, 2021 · 0 comments · Fixed by #1306
Closed

Update tests in test_deep_feature_synthesis.py #1305

thehomebrewnerd opened this issue Jan 12, 2021 · 0 comments · Fixed by #1306
Assignees

Comments

@thehomebrewnerd
Copy link
Contributor

Update tests in test_deep_feature_synthesis.py

The tests in tests/synthesis/test_deep_feature_synthesis.py appear to be testing various aspects of the DeepFeatureSynthesis object. There are a few tests in this file that generate a list of features using a call to ft.dfs. These tests could be updated to use a call to DeepFeatureSynthesis.build_features() instead. This would better align with the other tests in the file, and would improve test clarity as they are not testing any other aspects of the dfs method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant