Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call _handle_nullable_types in fit, transform, predict #3993

Closed
tamargrey opened this issue Feb 13, 2023 · 0 comments · Fixed by #4046
Closed

Call _handle_nullable_types in fit, transform, predict #3993

tamargrey opened this issue Feb 13, 2023 · 0 comments · Fixed by #4046
Assignees
Labels
new feature Features which don't yet exist.

Comments

@tamargrey
Copy link
Contributor

tamargrey commented Feb 13, 2023

The first step in using the component-specific nullable type handling will be to actually call _handle_nullable_types for the components that need it. This will involve updating the necessary components and any resulting test changes.

class MyTransformer(Transformer):
    # We can handle nullable types automatically if we want to
    def fit(self, X, y):
      ...
      X, y = self._handle_nullable_types(X, y)
      ...

# A component with more specific needs 
class MyEstimator(Estimator):
    # We can handle nullable types automatically if we want to 
    def predict(self, X):
      ...
      X, y = self._handle_nullable_types(X)
      ...

As part of this ticket we should also

  • Understand the impact to automl search runtimes (expected to be increased, but the nullable types transformer would still be doing the actual transforming)
  • Test use of nullable types at the pipeline level

This should not be merged into main until the rest of the needed changes to automl search to remove existing handlings
have been made. They should all be merged to main at the same time.

@tamargrey tamargrey added the new feature Features which don't yet exist. label Feb 13, 2023
@tamargrey tamargrey changed the title Call _handle_nullable_types in fit, transform, predict, and objective_function Call _handle_nullable_types in fit, transform, predict Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Features which don't yet exist.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant