-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oversampler: Add nullable type handling for nullable y #3974
Comments
Not fixed by updating to sklearn 1.2.1 |
As part of implementing component-specific handling for the Oversampler, we need to remove the nullable type logic in the BaseSampler's _prepare_data. Also worth noting - this wasn't even maintaining woodwork types causing us to rerun type inference, which would be unnecessary computation and potentially cause a bug if we lost some column types that were influencing the type of sampler we chose. |
The Oversampler's nullable type incompatibility is fixed by upgrading to sklearn 1.2.2, but we should still rmeove the nullable type logic that is now doubly unnecessary in _prepare_data |
The following block of code will raise the
ValueError: Unknown label type: 'unknown'
error.This will not currently be seen in automl search because of the replace nullable types component, but we should consider adding nullable handling into the component class itself so that it can independently support nullable types.
Note this is likely related to #3923, #3922 , and #3910 , which all stem from the inability of sklearn's type_of_target to assign a proper type to nullable data
The text was updated successfully, but these errors were encountered: