Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of BaseSampler's Transform #2273

Closed
chukarsten opened this issue May 14, 2021 · 2 comments · Fixed by #2583
Closed

Handling of BaseSampler's Transform #2273

chukarsten opened this issue May 14, 2021 · 2 comments · Fixed by #2583
Assignees
@angela97lin
Labels
enhancement An improvement to an existing feature. refactor Work being done to refactor code.
Milestone
One Week Sprint

Comments

@chukarsten
Copy link
Contributor

chukarsten commented May 14, 2021 •
edited
Loading

Connected to the hotfix for 0.24.0 #2272 this issue covers the proper handling of BaseSampler's transform() return and how it's being changed to return None for y.

Successful completion of this involves proper testing to replace test_undersampler in tests/model_understanding_tests/test_permutation_importance.py.
@chukarsten
Copy link
Contributor Author

@dsherry @freddyaboulton @angela97lin placeholder for now...too tired to put in the rest of the details, haha.

@dsherry
Copy link
Contributor

dsherry commented May 14, 2021

My spike #2210 would fix this!

@dsherry dsherry added enhancement An improvement to an existing feature. refactor Work being done to refactor code. labels May 14, 2021
@dsherry dsherry self-assigned this May 18, 2021
@chukarsten chukarsten added this to the One Week Sprint milestone May 27, 2021
@dsherry dsherry assigned angela97lin and unassigned dsherry Jul 6, 2021
@angela97lin angela97lin mentioned this issue Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angela97lin angela97lin

Labels
enhancement An improvement to an existing feature. refactor Work being done to refactor code.
Projects
None yet
Milestone
One Week Sprint
3 participants
@dsherry @angela97lin @chukarsten