fix: Prevent error when maxTrashcanContents is 0 (google#5739)

* fix: Prevent error when maxTrashcanContents is 0 Resolves google#5729. * Eliminate ’smart’ quotes.
alschmiedt · Nov 30, 2021 · 341dba5 · 341dba5
1 parent 2ca6740
commit 341dba5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/core/interfaces/i_positionable.js b/core/interfaces/i_positionable.js
@@ -43,7 +43,7 @@ IPositionable.prototype.position;
 /**
  * Returns the bounding rectangle of the UI element in pixel units relative to
  * the Blockly injection div.
- * @return {?Rect} The UI elements’s bounding box. Null if
+ * @return {?Rect} The UI elements's bounding box. Null if
  *   bounding box should be ignored by other UI elements.
  */
 IPositionable.prototype.getBoundingRectangle;

diff --git a/core/trashcan.js b/core/trashcan.js
@@ -387,7 +387,7 @@ Trashcan.prototype.hasContents_ = function() {
  * @return {boolean} True if the trashcan contents-flyout is currently open.
  */
 Trashcan.prototype.contentsIsOpen = function() {
-  return this.flyout.isVisible();
+  return !!this.flyout && this.flyout.isVisible();
 };
 
 /**
@@ -480,7 +480,7 @@ Trashcan.prototype.position = function(metrics, savedPositions) {
 /**
  * Returns the bounding rectangle of the UI element in pixel units relative to
  * the Blockly injection div.
- * @return {?Rect} The UI elements’s bounding box. Null if
+ * @return {?Rect} The UI elements's bounding box. Null if
  *   bounding box should be ignored by other UI elements.
  */
 Trashcan.prototype.getBoundingRectangle = function() {

diff --git a/core/zoom_controls.js b/core/zoom_controls.js
@@ -234,7 +234,7 @@ ZoomControls.prototype.dispose = function() {
 /**
  * Returns the bounding rectangle of the UI element in pixel units relative to
  * the Blockly injection div.
- * @return {?Rect} The UI elements’s bounding box. Null if
+ * @return {?Rect} The UI elements's bounding box. Null if
  *   bounding box should be ignored by other UI elements.
  */
 ZoomControls.prototype.getBoundingRectangle = function() {