Generate ROS nodes on Windows #361
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphaville
added
bug
|
@ruairimoran could you please test this on Windows? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Although ROS (v1) does not run on Windows, OpEn will generate a ROS package without the generated static library file (which is a DLL file on Windows, which cannot be used in ROS). At the same time, a warning is printed in the console telling the user they will not be able to use the generated ROS node and they will have to compile it on Linux by themselves.
Alongside, the user should not be allows to generate a ROS node unless they have built the optimiser. The reason is that it relies on Python bindings, which are auto-generated by cargo.
Associated Issues
TODOs
CHANGELOG(s)CHANGELOG,Cargo.tomlandVERSION)