Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose response headers with :as file and :as buffer #61

Open
josephmturner opened this issue Jun 13, 2024 · 2 comments
Open

Expose response headers with :as file and :as buffer #61

josephmturner opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@josephmturner
Copy link
Contributor

Currently, it's not possible to access response headers when sending GET requests :as file. Is there a backward-compatible way to support this?

@josephmturner josephmturner changed the title Expose headers with :as file Expose response headers with :as file Jun 13, 2024
@alphapapa
Copy link
Owner

I'm not sure what you mean by backward-compatible here. It would need to be specified as a new value for :as, maybe something like :as '(response :with file), :as '(response :with buffer), etc. Hard to say what the best way to do it is.

@alphapapa alphapapa self-assigned this Jun 13, 2024
@alphapapa alphapapa added the enhancement New feature or request label Jun 13, 2024
@alphapapa alphapapa added this to the Future milestone Jun 13, 2024
@josephmturner
Copy link
Contributor Author

:as '(response :with file) and :as '(response :with buffer) make sense! My concern about backward-compatibility would only be relevant if we attempted to change the existing :as 'file handler to also return headers. Moot point. :)

@josephmturner josephmturner changed the title Expose response headers with :as file Expose response headers with :as file and :as buffer Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants