-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
org-ql-find fails when helm-completion-style set to 'emacs #337
Comments
shrug That looks to me like a problem with Helm, not with Anyway, if you're using Helm, you could just use |
It's due to the way One aspect that would need more work, though, is the annotations/affixations are off. I'd have to look into it more to see how to deal with that, but if we could figure that out, it may obviate the need for helm-org-ql. |
Ok, thanks, I'll look at this again. Maybe I can get that fix in for v0.7.1. |
I'm on vanilla Emacs 28.1 with helm as my completion framework, but unlike progfolio I have helm-completion-style set to 'helm, not to 'emacs. I recently installed org-ql and helm-org-ql from Melpa. The helm-org-ql commands all worked, but none of the org-ql-find commands did anything and no error messages appeared either. The only other one that didn't do anything was the org-ql-refile command. The rest of the org-ql commands did work. Thanks for your work on this great addition to org mode. |
Going to target this for v0.8 (or possibly a v0.7.3). |
This let-binding also breaks recursive minibuffers. M-x org-ql-find RET followed by C-x b *M TAB complains about invalid completion style (basic in my case) as shown in OP. I use the default Emacs completion framework. |
@progfolio Thanks for that. Do you mean that, if the @Vizs Would you be able to test and confirm whether that solution seems to work? |
Adam Porter ***@***.***> writes:
@progfolio Thanks for that. Do you mean that, if the
org-ql-completing-read style is
added to the front of completion-styles-alist rather than
replacing it, annotations and
affixations don't work?
That was the case at the time of that comment.
Helm has had quite a few commits since then, so I'm not sure if
that's still the case.
|
Oh, you mean it only broke annotations and affixations on Helm? I thought you meant on Vertico. |
I don't use Vertico, so I'm not sure how it works there. |
For @Vizs's problem with recursive minibuffers I think it should work to use |
Sorry for the late reply, prepending org-ql-completing-read completion-style to completion-style-alist fixes my problem. The diff below is what I use on my end to fix the issue.
|
Unfortunately, I can't get this to work with Helm with either the |
If I set the buffer-local value of (setq-local completion-styles '(basic partial-completion))
My global value of I set Mentioning this here instead of in a new thread since the cause of the problem is the same: let-binding completion-styles-alist instead of prepending to it. Progfolio's suggestion above fixes it:
|
Originally posted by @progfolio in #284 (comment)
Bisected my helm configuration. Reliably reproducable on my end when the
helm-completion-style
option is set to'emacs
. Leaving that option at its default value prevents the error, but theorg-ql-find
candidate list is empty.The text was updated successfully, but these errors were encountered: