Guard against obscure bug in test setup #3308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try to freeze time to before 2011 you get the following obscure exception from somewhere within itsdangerous: ``` timestamp = base64_encode(int_to_bytes(self.get_timestamp())) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ num = -1 def int_to_bytes(num): > assert num >= 0 E AssertionError ``` Something in there is baselining `timestamp` to `0` at the start of 2011. Which means that trying to freeze time to before then results in a negative timestamp. This is a very non-obvious exception to see, so hopefully raising a specific exception instead will save others some time.
quis
force-pushed
the
guard-freezetime-bug
branch
from
5317e5a to
238142f
Compare
|
It seems like the timestamp thing was a bug in the version of itsdangerous that we are using that has now been fixed (pallets/itsdangerous#46). So we could just try and bump itsdangerous instead - we shouldn't need to pin it to |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to freeze time to before 2011 you get the following obscure exception from somewhere within itsdangerous:
Something in there is baselining
timestampto0at the start of 2011. Which means that trying to freeze time to before then results in a negative timestamp.This is a very non-obvious exception to see, so hopefully raising a specific exception instead will save others some time.