fix: [GW-2013] Update Gems, Fix Test, Update Templates, fix docker #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonaAtkins
added
enhancement
leonaAtkins
force-pushed
the
GW-2013_fix_security_issue
branch
from
d38e7ab to
14027bb
Compare
…ifi-user-signup-api into GW-2013_fix_security_issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update Docker image with Ruby version, replaced run task with one used in other api's, updated Gems and templates, and fixed the failing unit tests.
Why
To resolve a security issue with some of the libraires and bring the build process up to date and inline with the other API's
Deployment
I've built and deployed this to Dev, deployed and smoke tests passed.
Link to Jira card (if applicable):
https://technologyprogramme.atlassian.net/browse/GW-2013