-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide which versions of Node we officially support #1124
Comments
When we eventually consider dropping Node 12 support, we must remember to look at our lockfile version: #1151 |
I'd like to do this as part of the release for v13 of the kit, as this is a breaking change, but something we should do soon. In my opinion we should definitely drop support for Node 12, and also consider dropping support for Node 14. Node 14 is currently in maintenance mode, reaching end-of-life in April next year [1], while Node 12 reached end-of-life in April this year [2]. These two versions also are distributed with npm 6, which is also a legacy version [3] and has a number of bugs and missing features. |
Team discussion initially - Ruth to set up an initial 30 minute session next sprint
Info needed for session:
|
One thing we should also consider for this ticket is how we want to update the One thing I think we should consider is removing the upper limit. I did a search, and no package we depend on has an upper limit on the version of Node it supports in the engines directive. I also had a look at some other popular packages we don’t depend on, and none of those had an upper limit. I think it is not common practice. We could also consider making it clearer we only support LTS releases, similar to how other packages do, by only including even numbers in the version range. @colinrotherham made a suggestion similar to this in #1700 (comment). |
Arguments for not supporting v14 from @nataliecarey:
|
As this decision is blocking v13 work, I'm happy to make the call that we support 16 and 18 only. In terms of a policy for how we support versions going forward, I propose that once a version is in maintenance and within 6 months or less from end of life, we stop providing support for it. |
v13 now supports Node 16 and 18 only (see #1753). I'll also update the README to include a note about how we decide what versions of Node to support going forward. |
What
We should decide which versions of Node we test on and officially support, and we should implement this decision.
Why
We currently test Node version 12, 14, 16 and 18. v12 is no longer supported, v14 will reach end of life in April, v16 entered maintenance in October, and v18 is the current release.
Who needs to work on this
Developer, Content Designer
Who needs to review this
Developer, Product Manager?
Done when
The text was updated successfully, but these errors were encountered: