Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate effects of enabling TypeScript's skipLibCheck #5549

Open
2 tasks
romaricpascal opened this issue Dec 9, 2024 · 0 comments
Open
2 tasks

Investigate effects of enabling TypeScript's skipLibCheck #5549

romaricpascal opened this issue Dec 9, 2024 · 0 comments

Comments

@romaricpascal
Copy link
Member

What

Investigate if enabling TypeScript's skipLibCheck option helps avoid TypeScript throwing errors when dependencies have issues in the types they provide or their implementation. Ideally we'd want:

  • not to error if a 3rd party dependency has type issues
  • error if we misuses or have type issues amongst our own packages (eg. calling code from shared)

Especially:

  • would we still be confident what we shipped is correctly typed?
  • which kinds of errors would we open ourselves to in the future?

Why

We've now had several Dependabot PRs stuck because of type issues from 3rd parties, clogging our list of dependency updates over something we don't have control of:

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We understand what effects skipLibCheck has on our project
  • We decided whether to enable it or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant