Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move src and built package files under the same package #3547

Closed
4 tasks done
Tracked by #3291
romaricpascal opened this issue Apr 25, 2023 · 0 comments · Fixed by #3491 or #3498
Closed
4 tasks done
Tracked by #3291

Move src and built package files under the same package #3547

romaricpascal opened this issue Apr 25, 2023 · 0 comments · Fixed by #3491 or #3498
Labels
Milestone

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Apr 25, 2023

What

Move the src and built package files under a same package, allowing to share dependencies in a common package.json.
Keep shipping only the built files, excluding the source files from the package distributed on npm (either via .npmignore or the "files" field in package.json).

This change will affect longstanding pieces of work, like Exit this page or Tasklist, so we'll need to make sure to help these branches get rebased.

Why

Details for this decision can be found in our architecture repository

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

Tasks

@romaricpascal romaricpascal changed the title Move src and built files under the same package Move src and built package files under the same package Apr 25, 2023
@romaricpascal romaricpascal added this to the v5.0 milestone Apr 25, 2023
@romaricpascal romaricpascal moved this from Backlog 🗄 to Needs review 🔍 in GOV.UK Design System cycle board Apr 25, 2023
@romaricpascal romaricpascal linked a pull request Apr 25, 2023 that will close this issue
@romaricpascal romaricpascal moved this from Needs review 🔍 to In progress 📝 in GOV.UK Design System cycle board Apr 25, 2023
@romaricpascal romaricpascal moved this from In progress 📝 to Backlog 🗄 in GOV.UK Design System cycle board Apr 25, 2023
@romaricpascal romaricpascal moved this from Backlog 🗄 to Needs review 🔍 in GOV.UK Design System cycle board May 4, 2023
@romaricpascal romaricpascal moved this from Needs review 🔍 to In progress 📝 in GOV.UK Design System cycle board May 4, 2023
@romaricpascal romaricpascal reopened this May 4, 2023
@colinrotherham colinrotherham moved this from In progress 📝 to Ready to release 🚀 in GOV.UK Design System cycle board May 19, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
1 participant