Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy font setting and tabular font separation setting from codebase #2791

Closed
8 tasks done
Tracked by #2769
owenatgov opened this issue Aug 19, 2022 · 0 comments · Fixed by #3574
Closed
8 tasks done
Tracked by #2769

Remove legacy font setting and tabular font separation setting from codebase #2791

owenatgov opened this issue Aug 19, 2022 · 0 comments · Fixed by #3574
Assignees
@querkmachine
Labels
breaking change tech debt
Milestone
v5.0

Comments

@owenatgov
Copy link
Contributor

owenatgov commented Aug 19, 2022 •
edited by querkmachine
Loading

What

Remove the setting $govuk-use-legacy-font and all its uses in govuk-frontend, as well as the settings it informs:

Why

Required to remove compatibility mode completely from govuk-frontend in 5.0.

Part of #2769

Who needs to work on this

Developers

Done when

  • Remove from back link component
  • Remove from breadcrumbs component
  • Remove from button component
  • Remove from header component
  • Remove from tag component
  • Remove font family file and re-write font definition to always point to GDS Transport
  • Remove $govuk-font-family-tabular and reconfigure govuk-font
  • Remove setting completely
@owenatgov owenatgov mentioned this issue Aug 19, 2022
Closed
@owenatgov owenatgov added this to the v5.0 milestone Aug 19, 2022
@querkmachine querkmachine self-assigned this May 4, 2023
@querkmachine querkmachine moved this from Backlog 🗄 to In progress 📝 in GOV.UK Design System cycle board May 4, 2023
@querkmachine querkmachine mentioned this issue May 4, 2023
Merged
@querkmachine querkmachine linked a pull request May 4, 2023 that will close this issue
Remove legacy and tabular fonts support #3574
Merged
@querkmachine querkmachine moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board May 4, 2023
@querkmachine querkmachine moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board May 4, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@querkmachine querkmachine

Labels
breaking change tech debt
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Remove legacy and tabular fonts support alphagov/govuk-frontend
3 participants
@querkmachine @kellylee-gds @owenatgov