-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated govuk-main-wrapper
mixins
#1379
Comments
Wonder if we should use |
Will we need to update the spacing mixins guidance? Or just tell users in the release notes? |
main-wrapper
mixins
Thanks @EoinShaughnessy , good shout. I don't think the spacing mixins guidance needs updating, but it looks like we do reference these mixins in https://design-system.service.gov.uk/styles/layout/#page-wrappers |
main-wrapper
mixinsgovuk-main-wrapper
mixins
@EoinShaughnessy Having had another look at the design system, I don't think any guidance on there needs updating as we only refer to the The Frontend Docs does reference these mixins, but that should automatically update once we release v4.0.0 and update the frontend docs repo to use that version. |
@vanitabarrett Ah great, thanks - good to know! |
What
Remove a deprecated feature:
govuk-main-wrapper
andgovuk-main-wrapper--l
mixins. Instead, people should replace this mixin with more direct references to the spacing mixinsWhy
The
govuk-main-wrapper
andgovuk-main-wrapper--l
mixins were marked as deprecated in v3.0.0We're not sure these are useful, so these will be removed in a future release, if you are using either of these please let us know.
Who needs to know about this
Developers, Tech Writer
Done when
govuk-main-wrapper
mixin has been removedgovuk-main-wrapper--l
mixin has been removedDetails of breaking change
govuk-main-wrapper
orgovuk-main-wrapper--l
mixins in their Sassgovuk-main-wrapper
andgovuk-main-wrapper--l
Sass mixinsThe text was updated successfully, but these errors were encountered: