Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated govuk-main-wrapper mixins #1379

Closed
4 tasks done
Tracked by #2274
NickColley opened this issue May 28, 2019 · 5 comments · Fixed by #2385
Closed
4 tasks done
Tracked by #2274

Remove deprecated govuk-main-wrapper mixins #1379

NickColley opened this issue May 28, 2019 · 5 comments · Fixed by #2385
Assignees
Labels
breaking change 🕔 hours A well understood issue which we expect to take less than a day to resolve. sass / css
Milestone

Comments

@NickColley
Copy link
Contributor

NickColley commented May 28, 2019

What

Remove a deprecated feature: govuk-main-wrapper and govuk-main-wrapper--l mixins. Instead, people should replace this mixin with more direct references to the spacing mixins

Why

The govuk-main-wrapper and govuk-main-wrapper--l mixins were marked as deprecated in v3.0.0

We're not sure these are useful, so these will be removed in a future release, if you are using either of these please let us know.

Who needs to know about this

Developers, Tech Writer

Done when

  • govuk-main-wrapper mixin has been removed
  • govuk-main-wrapper--l mixin has been removed
  • Does any existing documentation refer to these mixins?
  • "Details of breaking change" section below completed to help with writing release notes

Details of breaking change

  • which users are affected: anyone using the govuk-main-wrapper or govuk-main-wrapper--l mixins in their Sass
  • the change that’s been made: we've removed the govuk-main-wrapper and govuk-main-wrapper--l Sass mixins
  • changes users will have to make: if they're using these mixins, they need to remove them. They can replace them with direct calls to our spacing mixins
  • impact of users not making those changes: if they're using these mixins and don't remove them, their Sass will start erroring because it won't be able to find the mixins anymore.
@NickColley NickColley modified the milestones: Next, v4.0.0 May 28, 2019
@timpaul timpaul added 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low labels Jun 5, 2019
@NickColley
Copy link
Contributor Author

Wonder if we should use @warn directives on these before 4.0.0 @36degrees ?

@EoinShaughnessy
Copy link
Contributor

Will we need to update the spacing mixins guidance? Or just tell users in the release notes?

@EoinShaughnessy EoinShaughnessy changed the title Remove deprecated main-wrapper mixins Remove deprecated main-wrapper mixins Sep 7, 2021
@vanitabarrett
Copy link
Contributor

Thanks @EoinShaughnessy , good shout. I don't think the spacing mixins guidance needs updating, but it looks like we do reference these mixins in https://design-system.service.gov.uk/styles/layout/#page-wrappers

@vanitabarrett
Copy link
Contributor

@EoinShaughnessy Having had another look at the design system, I don't think any guidance on there needs updating as we only refer to the govuk-main-wrapper and govuk-main-wrapper--l classes which will continue to exist after this change has been made. We are only removing the mixins.

The Frontend Docs does reference these mixins, but that should automatically update once we release v4.0.0 and update the frontend docs repo to use that version.

@EoinShaughnessy
Copy link
Contributor

@vanitabarrett Ah great, thanks - good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 🕔 hours A well understood issue which we expect to take less than a day to resolve. sass / css
Projects
Development

Successfully merging a pull request may close this issue.

6 participants