Fix compiler “Type 'boolean' is not assignable to type 'string'”

alphagov · Jan 18, 2023 · 08cf1d4 · 08cf1d4
1 parent 8416bc4
commit 08cf1d4
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/govuk/components/accordion/accordion.mjs b/src/govuk/components/accordion/accordion.mjs
@@ -335,7 +335,7 @@ Accordion.prototype.setExpanded = function (expanded, $section) {
     : this.i18n.t('showSection')
 
   $showHideText.innerText = newButtonText
-  $button.setAttribute('aria-expanded', expanded)
+  $button.setAttribute('aria-expanded', expanded.toString())
 
   // Update aria-label combining
   var ariaLabelParts = []
@@ -413,7 +413,7 @@ Accordion.prototype.updateShowAllButton = function (expanded) {
     ? this.i18n.t('hideAllSections')
     : this.i18n.t('showAllSections')
 
-  this.$showAllButton.setAttribute('aria-expanded', expanded)
+  this.$showAllButton.setAttribute('aria-expanded', expanded.toString())
   this.$showAllText.innerText = newButtonText
 
   // Swap icon, toggle class

diff --git a/src/govuk/components/character-count/character-count.mjs b/src/govuk/components/character-count/character-count.mjs
@@ -294,7 +294,7 @@ CharacterCount.prototype.updateScreenReaderCountMessage = function () {
   if (this.isOverThreshold()) {
     $screenReaderCountMessage.removeAttribute('aria-hidden')
   } else {
-    $screenReaderCountMessage.setAttribute('aria-hidden', true)
+    $screenReaderCountMessage.setAttribute('aria-hidden', 'true')
   }
 
   // Update message

diff --git a/src/govuk/components/checkboxes/checkboxes.mjs b/src/govuk/components/checkboxes/checkboxes.mjs
@@ -98,7 +98,7 @@ Checkboxes.prototype.syncConditionalRevealWithInputState = function ($input) {
   if ($target && $target.classList.contains('govuk-checkboxes__conditional')) {
     var inputIsChecked = $input.checked
 
-    $input.setAttribute('aria-expanded', inputIsChecked)
+    $input.setAttribute('aria-expanded', inputIsChecked.toString())
     $target.classList.toggle('govuk-checkboxes__conditional--hidden', !inputIsChecked)
   }
 }

diff --git a/src/govuk/components/header/header.mjs b/src/govuk/components/header/header.mjs
@@ -77,7 +77,7 @@ Header.prototype.syncState = function () {
     this.$menuButton.setAttribute('hidden', '')
   } else {
     this.$menuButton.removeAttribute('hidden')
-    this.$menuButton.setAttribute('aria-expanded', this.menuIsOpen)
+    this.$menuButton.setAttribute('aria-expanded', this.menuIsOpen.toString())
 
     if (this.menuIsOpen) {
       this.$menu.removeAttribute('hidden')

diff --git a/src/govuk/components/radios/radios.mjs b/src/govuk/components/radios/radios.mjs
@@ -98,7 +98,7 @@ Radios.prototype.syncConditionalRevealWithInputState = function ($input) {
   if ($target && $target.classList.contains('govuk-radios__conditional')) {
     var inputIsChecked = $input.checked
 
-    $input.setAttribute('aria-expanded', inputIsChecked)
+    $input.setAttribute('aria-expanded', inputIsChecked.toString())
     $target.classList.toggle('govuk-radios__conditional--hidden', !inputIsChecked)
   }
 }