Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update accessibility statement #4322

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update accessibility statement #4322

wants to merge 4 commits into from

Conversation

selfthinker
Copy link
Contributor

@selfthinker selfthinker commented Nov 22, 2024 •
edited by owenatgov
Loading

This updates the accessibility statement to:

  • be up-to-date with latest audits
  • refer to WCAG 2.2 instead of WCAG 2.1
  • fix some links that were previously leading to GitHub labels that have since been renamed
  • fix some stylistic issues:
    • add a heading for the "GOV.UK Design System website" section under "Preparation of this accessibility statement"
    • consistently use singular verb after "team"
    • and some other minor changes

This will close #4269.

Before this can be merged, two things need to happen:

  • Reformat search results metadata to be more verbose #4290 needs to be merged (as that is an outstanding fix for a WCAG fail).
  • The sentence "It was last reviewed and updated on 27 November 2024." needs to reflect the date of the merge. (I just picked a date that is close to when the actual date might be.)

@netlify Netlify
Copy link

netlify bot commented Nov 22, 2024 •
edited
Loading

✅ You can preview this change here:

Name Link
🔨 Latest commit e668de2
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/6740c254fc2d71000873f769
😎 Deploy Preview https://deploy-preview-4322--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

selfthinker
selfthinker commented Nov 22, 2024
View reviewed changes
src/accessibility-statement.md

Additional accessibility concerns from the GOV.UK Frontend codebase include:

1. The details component does not work well with Dragon and VoiceOver. This is not an issue with our details component, but is a known issue with the assistive technology and the `<details>` HTML element. Track our progress on the [GitHub issue: ‘Details component does not work well with Dragon and VoiceOver’](https://github.com/alphagov/govuk-frontend/issues/3693).
2. [A bug within Dragon means no action is taken when trying to activate the file upload component](https://github.com/alphagov/reported-bugs/issues/35) through the command ‘click choose file’. This is a usability issue originating from the assistive technology. The team does not plan to fix this, as the assistive technology will need to resolve it. Track our progress on the [GitHub issue: ‘Upload file component doesn’t respond to ‘click choose file’ due to Dragon / browser bugs’](https://github.com/alphagov/govuk-frontend/issues/3686).
1. The details component does not work well with Dragon and older versions of VoiceOver. This is not an issue with our details component, but is a known issue with the assistive technology and the `<details>` HTML element. Track our progress on the [GitHub issue: ‘Details component does not work well with Dragon and VoiceOver’](https://github.com/alphagov/govuk-frontend/issues/3693).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in an internal chat, the two GitHub issues listed here say to "track our progress". But both of those issues are closed and there is not much to track. The only way to track is via looking at all the issues that are linking to it, so not very user-friendly. We should maybe try to adjust the language (and therefore expectations), or change the links to point to an issues that explains more and really tracks it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense. I'm not sure which issue is best to link to but maybe the wording could be something like:

See the work we've done on this on the [Github issue etc etc]

Obviously needs more workshopping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have decided to keep the link but to add updated information to the issues these link to:

I think that means we can keep the way it is phrased now.

@selfthinker selfthinker mentioned this pull request Nov 22, 2024
Open
3 tasks
owenatgov
owenatgov reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a comment that on first pass I don't see any issues 👍🏻

I won't approve until we've resolved the thing with github issues that you mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenatgov owenatgov owenatgov left review comments

@calvin-lau-sig7 calvin-lau-sig7 Awaiting requested review from calvin-lau-sig7

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the website's accessibility statement
2 participants
@selfthinker @owenatgov