Update Manifest to V3, include mixed-mode tudor crown icons #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
update-manifest-to-v3-kml
branch
from
41f7a2b to
ae88148
Compare
Co-authored-by: Kashif Atcha <[email protected]> Co-authored-by: Jon Kirwan <[email protected]> Co-authored-by: Keith Lawrence <[email protected]>
Co-authored-by: Kashif Atcha <[email protected]> Co-authored-by: Jon Kirwan <[email protected]> Co-authored-by: Keith Lawrence <[email protected]>
- New Chrome APIs mean we can't detect dark mode in a service worker, so remove dark mode versions and add mixed-mode-safe icons of the Tudor crown Co-authored-by: Kashif Atcha <[email protected]> Co-authored-by: Jon Kirwan <[email protected]> Co-authored-by: Keith Lawrence <[email protected]>
- A/B testing component temporarily disabled to allow deploy Co-authored-by: Kashif Atcha <[email protected]> Co-authored-by: Jon Kirwan <[email protected]> Co-authored-by: Keith Lawrence <[email protected]>
Co-authored-by: Kashif Atcha <[email protected]> Co-authored-by: Jon Kirwan <[email protected]> Co-authored-by: Keith Lawrence <[email protected]>
Co-authored-by: Kashif Atcha <[email protected]> Co-authored-by: Jon Kirwan <[email protected]> Co-authored-by: Keith Lawrence <[email protected]>
- Temporarily disable A/B testing related code - chrome.tabe.executeScript -> chrome.scripting.executeScript (calling functions now have to be async) - Remove reliance on component states that might not be available in async code - explicit location parts in re-render popup code Co-authored-by: Kashif Atcha <[email protected]> Co-authored-by: Jon Kirwan <[email protected]> Co-authored-by: Keith Lawrence <[email protected]>
KludgeKML
force-pushed
the
update-manifest-to-v3-kml
branch
from
ae88148 to
1cbfa0a
Compare
KludgeKML
changed the title
KludgeKML
requested review from
minhngocd,
jon-kirwan,
kashifatcha and
MartinJJones
There was a problem hiding this comment.
NIce work removing this!
MartinJJones
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Nice work on this update!
I've checked the code and referred to the Migration guide and all looks good to me - https://developer.chrome.com/docs/extensions/develop/migrate
I've also tested the changes using the unpacked chrome extensions in my browser and all the functionality still works as expected, knowing that the functionality for AB tests will be added back in the future.
Closed
|
@KludgeKML are there any plans to add the ab test toggle back into the chrome extension? |
yndajas
added a commit
that referenced
this pull request
Oct 15, 2024
In its current state, and presumably since the [Manifest V3 migration](#186), the extension doesn't work on Firefox. However, it can be made fully functional with a small change When loading the extension in Firefox, the following is reported ``` There was an error during the temporary add-on installation. Error details background.service_worker is currently disabled ``` Firefox doesn't currently support `background.service_worker` in Manifest V3: https://bugzilla.mozilla.org/show_bug.cgi?id=1573659. This property was added when migrating to V3: #186 If you remove this section from the manifest, it will work on V3. The only caveat is that the icon won't change when on a GOV.UK page I also tried changing `service_worker` to `scripts` and using an array per [this suggestion](mozilla/web-ext#2532 (comment)), which also makes the extension functional, but doesn't make the icon-changing script work. I suspect the `icon.js` code would need updating for cross-browser support. Other suggestions later in that thread might be worth exploring, but it might make more sense to hold off until Firefox adds proper support if the user base is low
ChrisBAshton
pushed a commit
that referenced
this pull request
Oct 17, 2024
In its current state, and presumably since the [Manifest V3 migration](#186), the extension doesn't work on Firefox. However, it can be made fully functional with a small change When loading the extension in Firefox, the following is reported ``` There was an error during the temporary add-on installation. Error details background.service_worker is currently disabled ``` Firefox doesn't currently support `background.service_worker` in Manifest V3: https://bugzilla.mozilla.org/show_bug.cgi?id=1573659. This property was added when migrating to V3: #186 If you remove this section from the manifest, it will work on V3. The only caveat is that the icon won't change when on a GOV.UK page I also tried changing `service_worker` to `scripts` and using an array per [this suggestion](mozilla/web-ext#2532 (comment)), which also makes the extension functional, but doesn't make the icon-changing script work. I suspect the `icon.js` code would need updating for cross-browser support. Other suggestions later in that thread might be worth exploring, but it might make more sense to hold off until Firefox adds proper support if the user base is low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compromise release version to cope with the fact that we need to update the crown logo and V2 manifests can no longer be deployed to Chrome Web Store.
https://trello.com/c/liGfGsga/2174-migrate-to-a-service-worker