EmailValidator for wtforms: replace our own regex based routine with one stolen from Notify #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one stolen from Notify This will ensure we don't get any nasty surprises when attempting to send emails to addresses for which it's too late to display sensible validation error for. Largely copied from https://github.com/alphagov/notifications-utils/blob/67889886ec1476136d12e7f32787a7dbd0574cc2/notifications_utils/recipients.py#L439 onwards
risicle
force-pushed
the
ris-email-validator-from-notify
branch
from
777795a to
3207b0a
Compare
Wynndow
reviewed
Jul 23, 2018
| _INVALID_LOCAL_CHARS = r"\s\",;:@£“”‘’" | ||
| _email_regex = re.compile(r'^[^{}]+@([^.@][^@]+)$'.format(_INVALID_LOCAL_CHARS)) | ||
| _hostname_part = re.compile(r'^(xn-|[a-z0-9]+)(-[a-z0-9]+)*$', re.IGNORECASE) | ||
| _tld_part = re.compile(r'^([a-z]{2,63}|xn--([a-z0-9]+-)*[a-z0-9]+)$', re.IGNORECASE) |
There was a problem hiding this comment.
what's with the xns here and for the hostname?
There was a problem hiding this comment.
Wynndow
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/7m7tPP83/379-email-validation-should-we-use-notifys
https://trello.com/c/LD2eVPTY/368-supplier-user-can-be-created-but-no-email-sent
This is a fairly straightforward port. You'll see the tests needed minimal changes, mostly moving addresses over from what was previously considered "valid" to what's now considered "invalid" and making up a few replacement valid ones that are a bit tamer.
Thinking again, I'm actually probably going to make thisa major bump as technically the validator's constructor call signature has changed, not accepting a regex override as the previous implementation, inheriting from the regex validator, did.