Remove keys now at framework top level #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary We store key framework lifecycle dates at the top level of the framework record, so these values in the framework.frameworkAgreementDetails are duplicates. Let's consolidate by removing them. ## Ticket https://trello.com/c/82u630c9/80-remove-old-keys-from-frameworkagreementdetails
samuelhwilliams
force-pushed
the
shw-update-stubs
branch
from
92ac0a2 to
f8f928a
Compare
katstevens
approved these changes
Jun 12, 2018
Wynndow
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We store key framework lifecycle dates at the top level of the framework
record, so these values in the framework.frameworkAgreementDetails are
duplicates. Let's consolidate by removing them.
Ticket
https://trello.com/c/82u630c9/80-remove-old-keys-from-frameworkagreementdetails