Remove Python2 compatibility #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelhwilliams
requested review from
galund,
benvand,
TheDoubleK and
idavidmcdonald
TheDoubleK
approved these changes
Mar 15, 2018
samuelhwilliams
force-pushed
the
shw-remove-py2-tests
branch
from
56ea943 to
8360a17
Compare
|
@idavidmcdonald that makes a lot of sense. Done. |
samuelhwilliams
force-pushed
the
shw-remove-py2-tests
branch
from
8360a17 to
79dee6d
Compare
Bump to 35.0.0 as we are dropping Python3 compatibility. We've done a lot of work migrating our apps and libs to Python 3, so we are no longer actively looking to support Python 2. The only known things left running on Python 2 are a couple of scripts in dm-scripts, but we have tickets to update these to Python 3 in the immediate future and they are unlikely to be run before that happens.
samuelhwilliams
force-pushed
the
shw-remove-py2-tests
branch
from
79dee6d to
6389903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've done a lot of work migrating our apps and libs to Python 3, so we
are no longer actively looking to support Python 2. The only known
things left running on Python 2 are a couple of scripts in dm-scripts,
but we have tickets to update these to Python 3 in the immediate future
and they are unlikely to be run before that happens.
Our other libs with Python 2 tests running are dm-apiclient, dm-aws, and dm-content-loader.