Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove backwards compatibility for email importing #360

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Remove backwards compatibility for email importing #360

merged 2 commits into from
Feb 23, 2018

Conversation

benvand
Copy link
Contributor

@benvand benvand commented Feb 23, 2018

We no longer need this.

@benvand benvand merged commit 1c4e466 into master Feb 23, 2018
@benvand benvand deleted the remove-bc-email branch February 23, 2018 16:03
@risicle
Copy link
Contributor

risicle commented Feb 28, 2018

So what should https://github.com/alphagov/digitalmarketplace-brief-responses-frontend/blob/729b4b1a6bd0beb0ced75a3e2a662e3d66880f17/app/main/helpers/briefs.py#L41 do then?

@benvand
Copy link
Contributor Author

benvand commented Feb 28, 2018

Weird, how did that sneak past my greps.
It should be
from dmutils.email.dm_mandrill import send_email

@benvand
Copy link
Contributor Author

benvand commented Feb 28, 2018

https://github.com/alphagov/digitalmarketplace-brief-responses-frontend/pull/35/files

@risicle
Copy link
Contributor

risicle commented Feb 28, 2018

Thanks. I think you can imagine what my comment will be about this shouldn't be a problem we're having and architecture etc. so I'll spare you it.

@benvand
Copy link
Contributor Author

benvand commented Feb 28, 2018

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galund galund galund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benvand @risicle @galund