Add milliseconds to the log time format #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allait
force-pushed
the
millisecond-log-time-format
branch
from
c037055 to
1c13968
Compare
Wynndow
approved these changes
Oct 9, 2017
Allows keeping the order of events when logs are streamed to Kibana. Removing TIME_FORMAT argument from log formatters makes python use the default `formatTime` logic that adds `record.msec` to the formatted string. The default time format is the same as the one we define, except it uses a space instead of `T` to separate date from time. Since we don't rely on splitting fields with whitespace in JSON logs this shouldn't be a problem.
allait
force-pushed
the
millisecond-log-time-format
branch
from
1c13968 to
193e9c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows keeping the order of events when logs are streamed to Kibana.
Removing TIME_FORMAT argument from log formatters makes python use the default
formatTimelogic that addsrecord.msecto the formatted string. The default time format is the same as the one we define, except it uses a space instead ofTto separate date from time. Since we don't rely on splitting fields with whitespace in JSON logs this shouldn't be a problem.