Remove markdown filter from utils #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most, if not all of, the other repos have `Makefile`s. This one is a copy of the one in -frameworks.
This removes the markdown filter from our jinja templates going forward, so it's a breaking change. 💔
Domuments the removal of the markdown filter in README, as this is a breaking change.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to be able to use a
|markdownfilter in our jinja templates which would turn markdown formatted strings into Markup strings as well as permit HTML tags.This opened us up to vulnerabilities where untrusted input might end up going through one of these filters and expose us to a cross-site scripting (XSS) exploit.
Going forward, markdown formatted text will be allowed in specific fields (documented in the README for digitalmarketplace-frameworks) and then rendered by TemplateFields, handled by the Content Loader.