Extract content loader #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase, but looks good otherwise 👍 |
Content loader has been extracted to a new package. content_loader.py and its tests have been moved to the new dmcontent package. The new package can be found here - https://github.com/alphagov/digitalmarketplace-content-loader
The format_price function in dmutils.formats was only used by content loader so it has been moved to the new package. The format_service_price function is dependent on format_price so has been moved too. It is however used by the front end apps - they will need updating to import it from the new location. The relevant tests have been moved to the new package.
The tests for document.py had a dependency on ContentSection from the content_loader. As it has now been moved to a new package, the dependency has been mocked.
Wynndow
force-pushed
the
extract_content_loader
branch
from
611f6cd to
7092e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the content loader
Removes the
content_loader.pyfile and it's tests. They've been moved to a new package here: https://github.com/alphagov/digitalmarketplace-content-loaderRemoves a couple of functions from
formats.pyformat_priceandformat_service_pricehave both been moved to the new package asformat_priceis a dependency of the content loader, andformat_service_priceofformat_price. Tests have also been moved.Mock dependency on
test_documents.pytest_documents.pywas importingContentSectionfrom the content loader. As it's now been removed formdmutilsit makes sense to mock the dependency.