Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename selection answers to supplier declaration #178

Merged
merged 2 commits into from
Oct 8, 2015

Conversation

robyoung
Copy link
Contributor

@robyoung robyoung commented Oct 7, 2015

The language we have settled on for this is supplier declaration. This reflects the changes in Crown-Commercial-Service/digitalmarketplace-api#262

Depends on

robyoung added a commit to Crown-Commercial-Service/digitalmarketplace-supplier-frontend that referenced this pull request Oct 7, 2015
This brings in Crown-Commercial-Service/digitalmarketplace-utils#178 which changes the
`DataAPIClient` to match the language we use around the supplier
declaration.
@robyoung robyoung force-pushed the rename-selection-answers branch from ce826c8 to efa9036 Compare October 7, 2015 15:50
The language we have settled on for this is supplier declaration.
This reflects the changes in Crown-Commercial-Service/digitalmarketplace-api#262
@robyoung robyoung force-pushed the rename-selection-answers branch from efa9036 to 79b79cc Compare October 7, 2015 21:16
@allait
Copy link
Contributor

allait commented Oct 8, 2015

👍

This looks like a good time to suggest starting a CHANGELOG.md file for listing breaking changes in utils. Something as simple as: version, what was the breaking change, where to look for things that need to be changed in the app, example of before/after usage.

I'm happy to do this as a separate PR if everyone agrees this might be useful.

@TheDoubleK
Copy link
Contributor

@allait - yes, that would definitely be useful!

@robyoung robyoung force-pushed the rename-selection-answers branch from 055a3c0 to 71a3a7a Compare October 8, 2015 16:02
@robyoung robyoung force-pushed the rename-selection-answers branch from 71a3a7a to ac908e3 Compare October 8, 2015 16:18
robyoung added a commit that referenced this pull request Oct 8, 2015
Rename selection answers to supplier declaration
@robyoung robyoung merged commit ced4b23 into master Oct 8, 2015
@robyoung robyoung deleted the rename-selection-answers branch October 8, 2015 16:20
robyoung added a commit to Crown-Commercial-Service/digitalmarketplace-supplier-frontend that referenced this pull request Oct 8, 2015
This brings in Crown-Commercial-Service/digitalmarketplace-utils#178 which changes the
`DataAPIClient` to match the language we use around the supplier
declaration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants