-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy edit brief response manifest #330
Conversation
2a7297a
to
acead24
Compare
Don't know if this is a terrible idea, but throwing it out there anyway: another idea might be to have a 'version' number in the json somewhere, indicating which flow / version-of-flow is in use? The trouble with introducing 'legacy-this' and 'legacy-that' is that in the end, the new ones become legacy too, and then you get a problem :-D |
acead24
to
aecc4ed
Compare
George, good point. We had a discussion now about the plan forwards with this. We will be deprecating and removing the legacy manifests and legacy questions after a two week period after this launches. Because we can delete them we won't need to maintain multiple versions at the same and think we can go with "legacy" for the moment. We did discuss a versioning alternative but looks like we will be able to not have to do so. |
aecc4ed
to
a3fa42f
Compare
Currently paused on this pull request until we figure out some later steps in the process for handling multiple flows for applying for brief responses. |
abb275e
to
1daea91
Compare
1daea91
to
bddfa4a
Compare
We will be running two different manifests to edit a brief response for a period of two weeks. We therefore make the current manifest a legacy file. After two weeks this legacy manifest can then be removed. This will leave us with just one manifest which will have been nicely named `edit_brief_response`.
bddfa4a
to
fdb7750
Compare
👍 (also: thanks @galund for the input.) |
We will be running two different manifests to edit a brief response for a period of two weeks. We therefore make the current manifest a legacy file. After two weeks this legacy manifest can then be removed. This will leave us with just one manifest which will have been nicely named
edit_brief_response
.We've also introduced a change log because there wasn't one.