Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy edit brief response manifest #330

Merged
merged 3 commits into from
Nov 22, 2016

Conversation

idavidmcdonald
Copy link
Contributor

@idavidmcdonald idavidmcdonald commented Nov 15, 2016

We will be running two different manifests to edit a brief response for a period of two weeks. We therefore make the current manifest a legacy file. After two weeks this legacy manifest can then be removed. This will leave us with just one manifest which will have been nicely named edit_brief_response.

We've also introduced a change log because there wasn't one.

@galund
Copy link
Contributor

galund commented Nov 16, 2016

Don't know if this is a terrible idea, but throwing it out there anyway: another idea might be to have a 'version' number in the json somewhere, indicating which flow / version-of-flow is in use?

The trouble with introducing 'legacy-this' and 'legacy-that' is that in the end, the new ones become legacy too, and then you get a problem :-D

@idavidmcdonald idavidmcdonald force-pushed the legacy_edit_brief_response branch from acead24 to aecc4ed Compare November 16, 2016 17:09
@idavidmcdonald
Copy link
Contributor Author

George, good point. We had a discussion now about the plan forwards with this. We will be deprecating and removing the legacy manifests and legacy questions after a two week period after this launches. Because we can delete them we won't need to maintain multiple versions at the same and think we can go with "legacy" for the moment. We did discuss a versioning alternative but looks like we will be able to not have to do so.

@idavidmcdonald idavidmcdonald force-pushed the legacy_edit_brief_response branch from aecc4ed to a3fa42f Compare November 16, 2016 17:22
@idavidmcdonald idavidmcdonald changed the title Legacy edit brief response manifest and questions [WIP] Legacy edit brief response manifest and questions Nov 22, 2016
@idavidmcdonald
Copy link
Contributor Author

Currently paused on this pull request until we figure out some later steps in the process for handling multiple flows for applying for brief responses.

@idavidmcdonald idavidmcdonald force-pushed the legacy_edit_brief_response branch 3 times, most recently from abb275e to 1daea91 Compare November 22, 2016 14:21
@idavidmcdonald idavidmcdonald changed the title [WIP] Legacy edit brief response manifest and questions Legacy edit brief response manifest and questions Nov 22, 2016
@idavidmcdonald idavidmcdonald changed the title Legacy edit brief response manifest and questions Legacy edit brief response manifest Nov 22, 2016
@idavidmcdonald idavidmcdonald force-pushed the legacy_edit_brief_response branch from 1daea91 to bddfa4a Compare November 22, 2016 14:27
We will be running two different manifests to edit a brief response
for a period of two weeks. We therefore make the current manifest
a legacy file. After two weeks this legacy manifest can then
be removed. This will leave us with just one manifest which
will have been nicely named `edit_brief_response`.
@idavidmcdonald idavidmcdonald force-pushed the legacy_edit_brief_response branch from bddfa4a to fdb7750 Compare November 22, 2016 15:03
@tombye
Copy link
Contributor

tombye commented Nov 22, 2016

👍 (also: thanks @galund for the input.)

@idavidmcdonald idavidmcdonald merged commit 88bdd57 into master Nov 22, 2016
@idavidmcdonald idavidmcdonald deleted the legacy_edit_brief_response branch November 22, 2016 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants