Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Backup of ESP profiles fails if a mandatory app no longer exists #162

Closed
fmdkrenepedersen opened this issue Jan 30, 2024 · 5 comments · Fixed by #167
Closed

[BUG] Backup of ESP profiles fails if a mandatory app no longer exists #162

fmdkrenepedersen opened this issue Jan 30, 2024 · 5 comments · Fixed by #167
Assignees
Labels
bug Something isn't working verified The bug has been verified

Comments

@fmdkrenepedersen
Copy link

Describe the bug
Backup fails if a mandatory app no longer exists, during backup of ESP profiles.

To Reproduce
Steps to reproduce the behavior:

Delete an app that is selected as mandatory within a ESP profile.

Expected behavior
Continue backup even though a mandatory app is deleted.

Screenshots
image

image

Run type (please complete the following information):

  • Mode: Backup
  • Client Pipeline
  • Version 2.08
@fmdkrenepedersen fmdkrenepedersen added the bug Something isn't working label Jan 30, 2024
@almenscorner
Copy link
Owner

This is your queue to clean it up ;)

Jokes aside, I will include an extra check for empty app responses while backing up and skipping if the response is None so it will continue. I'll add that in an upcoming version.

@almenscorner almenscorner self-assigned this Jan 30, 2024
@almenscorner almenscorner added the verified The bug has been verified label Jan 30, 2024
@fmdkrenepedersen
Copy link
Author

Haha, point taken.

Thanks. Keep up the amazing work! Much appreciated :-)

@almenscorner
Copy link
Owner

This fix is now included in the latest beta, please do a test run and verify that the backup completes even if the app is removed.

To test, install the latest beta: pip3 install IntuneCD==2.0.9b1

@fmdkrenepedersen
Copy link
Author

Confirmed working with 2.0.9b1.

THANKS!

@almenscorner
Copy link
Owner

Fantastic :) I will close this issue once 2.0.9 is released!

@almenscorner almenscorner moved this from Requested to Started in IntuneCD roadmap Feb 13, 2024
@almenscorner almenscorner mentioned this issue Feb 13, 2024
@github-project-automation github-project-automation bot moved this from Started to Shipped in IntuneCD roadmap Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified The bug has been verified
Projects
Status: Shipped
Development

Successfully merging a pull request may close this issue.

2 participants