Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-alluredir command line argument removes only files from alluredir root #470

Closed
1 task
Caballero93 opened this issue Feb 23, 2020 · 0 comments · Fixed by #732
Closed
1 task

clean-alluredir command line argument removes only files from alluredir root #470

Caballero93 opened this issue Feb 23, 2020 · 0 comments · Fixed by #732

Comments

@Caballero93
Copy link

I'm submitting a ...

  • feature request

What is the current behavior?

When --clean-alluredir command line option is specified, it remove all the files from the root level of the alluredir. The problem is, when I copy history folder from already generated html report, which is something that is done if one wants to get historic trend graph in report: https://stackoverflow.com/a/50499775, this history folder is never cleared from report.

What is the expected behavior?

What I would expect is, when this argument is used, to clean whole directory from previous files and folders. I detected that the code for this argument is located in allure-python-commons/src/logger.py, and that fix is as easy as this: https://stackoverflow.com/a/185941.

What is the motivation / use case for changing the behavior?

What I want is to add option in my plugin to specify if I want to get historic trend or not. But with this in complete clean-alluredir option, once I choose not to have history folder in report, it will still be there.

Please tell us about your environment:

Other information

Since I know how to fix this issue easily, I am willing to contribute myself.

@Caballero93 Caballero93 changed the title clean-alluredir command line argument doesn't removes only files from alluredir root clean-alluredir command line argument removes only files from alluredir root Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants