Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nx-dropdown] An error appears when selecting any values in the drop down list #73

Closed
keeratita opened this issue Nov 11, 2024 · 3 comments

Comments

@keeratita
Copy link

keeratita commented Nov 11, 2024

⚑ Reproduction

Steps to reproduce:

  1. Go to a website : https://allianz.github.io/ng-aquila/welcome
  2. Try to select any values in a dropdown on Try it out section
  3. Got an error "Maximum call stack"

πŸ“— Expected Behavior

Should select the value in the dropdown list and show it/them properly.

πŸ“• Actual Behavior

error

πŸ“¦ Environment

  • Aquila/NDBX version: ^16.0.0
  • Angular/CDK version: ^16.0.1
  • Browser name & version: Brave Browser 1.71.123
  • Operating System & version (desktop or mobile): macOS Ventura 13.7.1
@keeratita keeratita changed the title [<component or scope>] <title> [Dropdownlist] An error appears when selecting any values in the drop down list Nov 11, 2024
@keeratita keeratita changed the title [Dropdownlist] An error appears when selecting any values in the drop down list [nx-dropdown] An error appears when selecting any values in the drop down list Nov 11, 2024
@keeratita
Copy link
Author

Should it have to use value attribute instead of nxValue in the <nx-dropdown-item>?

Source: src/app/starter-app.html

It seems the demo is working fine when changing these lines from

          <nx-dropdown-item nxValue="1">1</nx-dropdown-item>
          <nx-dropdown-item nxValue="2">2</nx-dropdown-item>
          <nx-dropdown-item nxValue="3">3</nx-dropdown-item>

to

          <nx-dropdown-item value="1">1</nx-dropdown-item>
          <nx-dropdown-item value="2">2</nx-dropdown-item>
          <nx-dropdown-item value="3">3</nx-dropdown-item>

@Phil147
Copy link
Contributor

Phil147 commented Nov 12, 2024

Hi @keeratita

Should it have to use value attribute instead of nxValue in the <nx-dropdown-item>?

Yes correct in v16 we removed the nx prefix in inputs for components. The starter app on the main page should get updated also to use the latest version.

@keeratita
Copy link
Author

Thanks a lot @Phil147.

@Phil147 Phil147 closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants