Adding PHPStan

[srtfisher]

• Moving code into inc and more modern structure
• Wiring up the legacy aliases and upgrading phpcs to alley cs 2.0
• Migrating tests into new namespace
• CHANGELOG and built release workflow
• Adding PHP 8.3, removing 8.0
• Adding editor config and test CS
• Migrating test suite to PSR-4
• Adjusting workflow
• Testing CI
• Testing CI
• Add types for array arguments
• Fix branch
• CHANGELOG
• Fixing types
• Test MS
• Contd work on phpstan

[szepeviktor]

You can specify the error ID.

Suggested change

	add_action( 'after_setup_theme', [ \Alley\WP\Asset_Manager\Preload::class, 'instance' ] ); // @phpstan-ignore-line should not return anything
	add_action( 'after_setup_theme', [ \Alley\WP\Asset_Manager\Scripts::class, 'instance' ] ); // @phpstan-ignore-line should not return anything
	add_action( 'after_setup_theme', [ \Alley\WP\Asset_Manager\Styles::class, 'instance' ] ); // @phpstan-ignore-line should not return anything
	add_action( 'after_setup_theme', [ \Alley\WP\Asset_Manager\SVG_Sprite::class, 'instance' ] ); // @phpstan-ignore-line should not return anything
	add_action( 'after_setup_theme', [ \Alley\WP\Asset_Manager\Preload::class, 'instance' ] ); // @phpstan-ignore return.void
	add_action( 'after_setup_theme', [ \Alley\WP\Asset_Manager\Scripts::class, 'instance' ] ); // @phpstan-ignore return.void
	add_action( 'after_setup_theme', [ \Alley\WP\Asset_Manager\Styles::class, 'instance' ] ); // @phpstan-ignore return.void
	add_action( 'after_setup_theme', [ \Alley\WP\Asset_Manager\SVG_Sprite::class, 'instance' ] ); // @phpstan-ignore return.void

[szepeviktor]

assert is a noop in production.

Suggested change

	add_action( $hook, [ $this, $function ], $priority ); // @phpstan-ignore-line expects callable
	assert( method_exists( $function, $this ) );
	add_action( $hook, [ $this, $function ], $priority );

[szepeviktor]

Annotations are much better for automatic hooking.
https://github.com/szepeviktor/SentencePress/blob/master/src/HookAnnotation.php
... or modern PHP attributes
https://github.com/boxuk/wp-hook-attributes?tab=readme-ov-file#usage

[srtfisher]

I usually do it with https://mantle.alley.com/docs/features/support/hookable#usage-with-attributes but this is an older plugin

[szepeviktor]

📡 What a space laser you have there!

[szepeviktor]

@srtfisher Please reach 0 errors on level 4. It is very close.