Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows Paths #487

Closed
kevinfodness opened this issue Dec 11, 2023 · 0 comments · Fixed by #489
Closed

Support Windows Paths #487

kevinfodness opened this issue Dec 11, 2023 · 0 comments · Fixed by #489
Assignees
@srtfisher
Labels
bug Something isn't working php Requires understanding PHP

Comments

@kevinfodness
Copy link
Member

Description of the bug

The code checks paths for "validity" by checking the return value of validate_file to ensure that it is 0, but a valid Windows filepath on a Windows system will return 2, making it so that this library cannot run on a Windows host (either for local development or via Windows Server).

Steps To Reproduce

  1. Install on a Windows host
  2. Attempt to use functionality that relies on validate_file, such as the asset loader

Additional Information

Should replace the validate_file check to ensure it returns either 0 or 2
@kevinfodness kevinfodness added bug Something isn't working php Requires understanding PHP labels Dec 11, 2023
@srtfisher srtfisher mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srtfisher srtfisher

Labels
bug Something isn't working php Requires understanding PHP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Windows Paths with validate_file() alleyinteractive/mantle-framework
2 participants
@srtfisher @kevinfodness