Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Default Caption Styling #1097

Merged

Conversation

dlh01
Copy link
Member

@dlh01 dlh01 commented Apr 10, 2024

Makes the caption styles more consistent between custom themes and establishes better spacing overall between images with captions and their surrounding text.

Fixes #1072

Copy link
Member

@kevinfodness kevinfodness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's on the right track - thanks for digging into the implications of this change so thoroughly.

@kevinfodness kevinfodness changed the base branch from develop to release/v2.5.0 April 12, 2024 20:58
@kevinfodness kevinfodness changed the title WIP: Default caption styling Improve Default Caption Styling Apr 12, 2024
@kevinfodness kevinfodness marked this pull request as ready for review April 12, 2024 22:03
Copy link

@attackant attackant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure is Kevin is still reviewing this also, but LGTM 👍🏼

@kevinfodness kevinfodness merged commit 0a784b4 into release/v2.5.0 Apr 15, 2024
8 checks passed
@kevinfodness kevinfodness deleted the feature/APPLE-170/improve-default-caption-styling branch April 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants