Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix paths in the code to be OS independent #335

Open
matt-gardner opened this issue May 3, 2017 · 3 comments
Open

Fix paths in the code to be OS independent #335

matt-gardner opened this issue May 3, 2017 · 3 comments

Comments

@matt-gardner
Copy link
Contributor

I'm pretty sure this won't work on Windows at the moment, because we have plenty of places where / is hard-coded, instead of using os.path.join. This should be fixed.

It's also super low priority for us, and really hard to know if we've found everything, because we just use linux and macOS. Contributions welcome here.

@morrme
Copy link
Contributor

morrme commented May 5, 2017

I use windows. How can I help?

@matt-gardner
Copy link
Contributor Author

Try running things, see what breaks, and submit PRs to fix it. If it just works already, then great, we can close this issue.

@nelson-liu
Copy link
Contributor

to be specific, it'd be great to verify that unit tests at least work on windows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants