Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop object return Status incorrect #54

Open
RajeshDM opened this issue Jul 14, 2024 · 0 comments
Open

Drop object return Status incorrect #54

RajeshDM opened this issue Jul 14, 2024 · 0 comments

Comments

@RajeshDM
Copy link

When dropping objects, we either get True or False based on whether the object was dropped.

In the case when the drop fails due to the agent not being in a good position to drop it from, the function goes on to see if it can drop it in any of the receptacles.

It then checks if this drop was succesful :

if self.controller.last_event.metadata["lastActionSuccess"]:

If it was, it breaks out of the loop. Now, since the drop was succesful and list of possible_receptacles is not empty, the function returns a False. Should it not be returning a True as soon as it hits line 858? since the object was dropped in one of the receptacles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant