From 73b92a6efd9c74ad000b8f1fa2ab6bdcc95cea0d Mon Sep 17 00:00:00 2001 From: Jordi Salvador Date: Thu, 14 Jul 2022 19:05:46 +0200 Subject: [PATCH] Doc update + bug fix in data path constant --- README.md | 11 ++++++----- rearrange/procthor_rearrange/constants.py | 2 +- rearrange/procthor_rearrange/expert.py | 3 --- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 1279878..aaa3436 100644 --- a/README.md +++ b/README.md @@ -572,11 +572,11 @@ evaluation doesn't have to be run on each set separately. ### 🏘 ProcTHOR pre-training -Here we describe commands that can be used to generate a ProcTHOR-pretrained agent and +We include commands that can be used to generate a ProcTHOR-pretrained agent and then fine-tune it with the 2022 rearrange dataset. Please note that this only covers the 1-phase modality, for which we also provide a -[pre-trained and fine-tune checkpoint](https://prior-model-weights.s3.us-east-2.amazonaws.com/embodied-ai/rearrangement/one-phase/exp_iThorOnePhaseRGBClipResNet50FineTune_procthor180Msteps_ithor_splits_ithor_fine_tune_64_to_128_rollout_3Msteps_6Msteps__stage_02__steps_000016018675.pt). -We also provide scripts to generate new ProcTHOR datasets in case you want to try different episodes. +[pre-trained and fine-tuned checkpoint](https://prior-model-weights.s3.us-east-2.amazonaws.com/embodied-ai/rearrangement/one-phase/exp_iThorOnePhaseRGBClipResNet50FineTune_procthor180Msteps_ithor_splits_ithor_fine_tune_64_to_128_rollout_3Msteps_6Msteps__stage_02__steps_000016018675.pt). +We also provide scripts to generate new ProcTHOR datasets in case you want to try new episodes. #### Pre-train model in ProcTHOR (single machine) The following will take for about 10-14 days on an 8-GPU machine with 56 CPU cores: @@ -584,11 +584,12 @@ The following will take for about 10-14 days on an 8-GPU machine with 56 CPU cor allenact -b baseline_configs/one_phase/procthor one_phase_rgb_clip_dagger \ -s 12345 --config_kwargs '{"distributed_nodes":1}' ``` -We strongly recommend using a larger number of GPUs and computing nodes for this step, if possible. +We **strongly** recommend using a larger number of GPUs and computing nodes for this step. #### ProcTHOR mini-valid -Run ProcTHOR mini-valid on checkpoints under the CKPT_DIR directory: +Run ProcTHOR mini-valid on checkpoints under a `CKPT_DIR` directory: ```bash +inv make-valid-houses-file allenact -b baseline_configs/one_phase/procthor/eval eval_minivalid_procthor \ -s 12345 --eval --approx_ckpt_step_interval 5e6 -c CKPT_DIR ``` diff --git a/rearrange/procthor_rearrange/constants.py b/rearrange/procthor_rearrange/constants.py index 10aa9ec..6374f8a 100644 --- a/rearrange/procthor_rearrange/constants.py +++ b/rearrange/procthor_rearrange/constants.py @@ -3,7 +3,7 @@ STARTER_DATA_DIR = os.path.join( - os.path.abspath(os.path.dirname(Path(__file__))), "../data", "2022procthor", + os.path.abspath(os.path.dirname(Path(__file__))), "../../data", "2022procthor", ) PROCTHOR_COMMIT_ID = "90eac925dc750818890069e3131f899998dc58b4" diff --git a/rearrange/procthor_rearrange/expert.py b/rearrange/procthor_rearrange/expert.py index 6ab5abb..0c2d581 100644 --- a/rearrange/procthor_rearrange/expert.py +++ b/rearrange/procthor_rearrange/expert.py @@ -1369,9 +1369,6 @@ def test( except: return - # submodule - sys.path.append("ai2thor_rearrangement") - init_logging("debug") test( stage="debug",