-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1905 | Added reason field to subscription/topic constraints #1913
Merged
szczygiel-m
merged 5 commits into
allegro:master
from
adriansobolewski:1905-constraint-changes-reason
Nov 17, 2024
Merged
#1905 | Added reason field to subscription/topic constraints #1913
szczygiel-m
merged 5 commits into
allegro:master
from
adriansobolewski:1905-constraint-changes-reason
Nov 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansobolewski
force-pushed
the
1905-constraint-changes-reason
branch
3 times, most recently
from
October 16, 2024 13:10
43cb994
to
2c64de9
Compare
adriansobolewski
force-pushed
the
1905-constraint-changes-reason
branch
from
October 16, 2024 13:12
2c64de9
to
6b80eb5
Compare
adriansobolewski
changed the title
1905 | Added reason field to subscription/topic constraints
#1905 | Added reason field to subscription/topic constraints
Oct 16, 2024
adriansobolewski
force-pushed
the
1905-constraint-changes-reason
branch
from
October 16, 2024 15:44
3f503fb
to
b9cc043
Compare
szczygiel-m
approved these changes
Oct 30, 2024
import org.hibernate.validator.internal.engine.ConstraintViolationImpl | ||
import spock.lang.Specification | ||
|
||
class SubscriptionConstraintsValidationTest extends Specification { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
pitagoras3
approved these changes
Nov 8, 2024
Great pull request @adriansobolewski, thank you for preparing tests for both backend and frontend part 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests results:
TC1 - empty reason insert
TC2 - correct reason insert
TC3 - reason edit
TC4 - reason upsert
TC5- too long reason text