Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1905 | Added reason field to subscription/topic constraints #1913

Merged

Conversation

adriansobolewski
Copy link
Contributor

@adriansobolewski adriansobolewski commented Oct 16, 2024

Tests results:
TC1 - empty reason insert
TC1_empty_reason
TC1_result
TC2 - correct reason insert
TC2_correct_reason_insert
TC2_result
TC3 - reason edit
TC3_reason_edit
TC4 - reason upsert
TC4_reason_upsert
TC4_result
TC5- too long reason text
TC5_too_long_reason
TC5_result

@adriansobolewski adriansobolewski force-pushed the 1905-constraint-changes-reason branch 3 times, most recently from 43cb994 to 2c64de9 Compare October 16, 2024 13:10
@adriansobolewski adriansobolewski changed the title 1905 | Added reason field to subscription/topic constraints #1905 | Added reason field to subscription/topic constraints Oct 16, 2024
import org.hibernate.validator.internal.engine.ConstraintViolationImpl
import spock.lang.Specification

class SubscriptionConstraintsValidationTest extends Specification {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@pitagoras3
Copy link
Contributor

pitagoras3 commented Nov 8, 2024

Great pull request @adriansobolewski, thank you for preparing tests for both backend and frontend part 🎉

@szczygiel-m szczygiel-m merged commit 762d389 into allegro:master Nov 17, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants