new integration tests framework publishing tests #1789
Conversation
moscicky
changed the title
| @Bean | ||
| @Primary | ||
| @Profile("integration") | ||
| HeadersPropagator traceHeadersPropagator() { |
There was a problem hiding this comment.
There is no need for creating this bean, You can achieve the same with config properties:
"--frontend.header.propagation.enabled=true", "--frontend.header.propagation.allowFilter=" + "Trace-Id, Span-Id, Parent-Span-Id, Trace-Sampled, Trace-Reported",
There was a problem hiding this comment.
good catch, removed beans
| .exchange(); | ||
| } | ||
|
|
||
|
|
| "--frontend.handlers.forceTopicMaxMessageSize=true", | ||
| "--frontend.throughput.type=fixed", | ||
| "--frontend.throughput.fixedMax=" + 50 * 1024L, | ||
| "--spring.profiles.active=integration" |
There was a problem hiding this comment.
Could You also turn on this profile in the management app to be consistent?
| // given | ||
| Topic topic = hermes.initHelper().createTopic(topicWithRandomName().build()); | ||
| TestSubscriber subscriber = subscribers.createSubscriber(); | ||
| hermes.initHelper().createSubscription(subscription(topic.getQualifiedName(), "subscription1", subscriber.getEndpoint()).build()); |
There was a problem hiding this comment.
We have a function which creates subscription with random name
There was a problem hiding this comment.
Which one? And does it matter if topics are random in the first place?
| manually sending different Content-Length than the actual message but servlet | ||
| container is smart enough to not invoke ReadListener.onAllDataRead() in that case. | ||
| */ | ||
| @SuppressWarnings("PMD.EmptyCatchBlock") |
There was a problem hiding this comment.
Is this SupressWaning needed?
moscicky
force-pushed
the
integration_tests_framework_slow_publish_tests
branch
from
fb95701
to
27eaea3
Compare
moscicky
force-pushed
the
integration_tests_framework_slow_publish_tests
branch
from
27eaea3
to
94b6c37
Compare
szczygiel-m
deleted the
integration_tests_framework_slow_publish_tests
branch
No description provided.